feat: add tracking for receive action #11695
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/smart-transactions-controller@13.0.0 |
|
|
| @@ -181,7 +181,7 @@ | |||
| "@metamask/selected-network-controller": "^15.0.2", | |||
| "@metamask/signature-controller": "^19.1.0", | |||
| "@metamask/slip44": "3.1.0", | |||
| "@metamask/smart-transactions-controller": "^13.0.0", | |||
| "@metamask/smart-transactions-controller": "^13.2.0", | |||
There was a problem hiding this comment.
can you explain pls why this upgrade is needed ?
There was a problem hiding this comment.
We need to import the new definitions from MetaMetricsEventCategory and MetaMetricsEventName, which are available on 13.2.0
| @@ -119,6 +119,7 @@ const AssetOverview: React.FC<AssetOverviewProps> = ({ | |||
| navigation.navigate(Routes.QR_TAB_SWITCHER, { | |||
| initialScreen: QRTabSwitcherScreens.Receive, | |||
| disableTabber: true, | |||
| origin: 'Token details', | |||
There was a problem hiding this comment.
Nit: origin is sometimes defined as part of AppConstants; definitely not a blocker
Description
This PR adds metrics tracking to the interactions with the "Receive" and "Request" features.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3260
Manual testing steps
Click on top QR for scanner, onReceive being ran should trigger a trackingEvent
Same thing for action button on lower menu
Same thing for asset in asset list
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist