Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add account_network section to re-designed confirmation page #11698

Merged
merged 8 commits into from
Oct 9, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Oct 9, 2024

Description

Add account and network section to re-designed confirmation pages.

Related issues

Fixes: #11680

Manual testing steps

  1. Enable re-designs locally
  2. Go to test dapp
  3. Submit personal sign and check page

Screenshots/Recordings

Screen.Recording.2024-10-09.at.10.26.17.AM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Oct 9, 2024
@jpuri jpuri requested review from a team as code owners October 9, 2024 04:50
Copy link
Contributor

github-actions bot commented Oct 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8193218
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4d5e5644-5861-4684-bd05-b2c9fa0ee7ba

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Oct 9, 2024

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 9, 2024
@jpuri jpuri enabled auto-merge October 9, 2024 07:15
@jpuri jpuri added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit 305f930 Oct 9, 2024
45 of 46 checks passed
@jpuri jpuri deleted the acc_network_info branch October 9, 2024 10:08
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.34.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add expandable account section on personal sign page
3 participants