Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Refactor EditAccountNameView for E2E tests #11765

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Oct 11, 2024

This PR refactors EditAccountNameView.js to adhere to E2E testing best practices by removing static methods converting them to instance methods and exporting an initialized class instance. The change-account-name.spec.js file is updated accordingly. Changes include refactoring EditAccountNameView.js updating change-account-name.spec.js and improving code readability. These modifications enhance the maintainability and consistency of the E2E tests for the account name editing functionality.

@devin-ai-integration devin-ai-integration bot added team-ai AI team (for the Devin AI bot) area-qa Relating to QA work (Quality Assurance) labels Oct 11, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@cortisiko cortisiko added the No QA Needed Apply this label when your PR does not need any QA effort. label Oct 11, 2024
@cortisiko cortisiko marked this pull request as ready for review October 11, 2024 22:13
@cortisiko cortisiko requested a review from a team as a code owner October 11, 2024 22:13
cortisiko
cortisiko previously approved these changes Oct 11, 2024
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

temp approval to place in merge queue

@cortisiko cortisiko added this pull request to the merge queue Oct 11, 2024
@cortisiko cortisiko removed this pull request from the merge queue due to a manual request Oct 11, 2024
@cortisiko cortisiko added this pull request to the merge queue Oct 11, 2024
@cortisiko cortisiko removed this pull request from the merge queue due to a manual request Oct 11, 2024
@cortisiko cortisiko added Run Smoke E2E Triggers smoke e2e on Bitrise DO-NOT-MERGE Pull requests that should not be merged labels Oct 11, 2024
@cortisiko cortisiko removed the DO-NOT-MERGE Pull requests that should not be merged label Oct 12, 2024
@cortisiko cortisiko removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 12, 2024
@cortisiko cortisiko added the DO-NOT-MERGE Pull requests that should not be merged label Oct 12, 2024
Copy link

sonarcloud bot commented Oct 12, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-qa Relating to QA work (Quality Assurance) DO-NOT-MERGE Pull requests that should not be merged No QA Needed Apply this label when your PR does not need any QA effort. team-ai AI team (for the Devin AI bot) team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant