Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Dependencies cleanup #11782

Merged
merged 5 commits into from
Oct 18, 2024
Merged

chore: Dependencies cleanup #11782

merged 5 commits into from
Oct 18, 2024

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Oct 14, 2024

Description

  • '@ethersproject/abi' - Can be cleaned from package.json since it's only used by dependencies
    image

  • @react-native-picker/picker - There is no usage for a picker anymore in the mobile app (Introduced here)
    image

  • @rnhooks/keyboard - There is no usage for @rnhooks/keyboard (introduced here)
    image

  • asyncstorage-down - there is no usage of asyncstorage-down ([introduced here]
    This one was added back, but most likely isn't needed and we need to think about replacing react-native-level-fs and use only one file system library

  • dnode - there is no usage of dnode (introduced here)
    image## Related issues
    imageFixes:

  • obs-store - There is no usage of obs-store anymoer (introruced here)
    image
    image

  • react-native-flash-message - there is no usage anymore (introduced here)
    image
    image

  • react-native-redash - there is no usage anymore (react-native-redash)
    image
    image

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise team-tiger Tiger team (for tech debt reduction + performance improvements) labels Oct 14, 2024
@tommasini tommasini requested review from a team as code owners October 14, 2024 14:34
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented Oct 14, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: cadd956
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3af7f5fb-549a-4412-9e95-f5b62d6dd510

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@tommasini tommasini marked this pull request as draft October 14, 2024 14:47
@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 15, 2024
Copy link
Contributor

github-actions bot commented Oct 15, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: cfeab8d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8bc7b275-d3b1-4681-bfaf-3eae628388fc

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@tommasini tommasini marked this pull request as ready for review October 15, 2024 13:37
joaoloureirop
joaoloureirop previously approved these changes Oct 15, 2024
Copy link
Contributor

@joaoloureirop joaoloureirop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-10-15 at 16 09 41

❤️

legobeat
legobeat previously approved these changes Oct 16, 2024
Copy link
Contributor

@legobeat legobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so_good

@tommasini tommasini dismissed stale reviews from legobeat and joaoloureirop via fc2e6a1 October 18, 2024 11:00
@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 18, 2024
Copy link
Contributor

github-actions bot commented Oct 18, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: fc2e6a1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/af7434ab-fcff-473e-9fa1-8e72483b5775

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Oct 18, 2024

@legobeat legobeat requested a review from a team October 18, 2024 11:14
@tommasini tommasini added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit 08d7a57 Oct 18, 2024
43 checks passed
@tommasini tommasini deleted the chore/deps-cleanup branch October 18, 2024 15:00
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform team-tiger Tiger team (for tech debt reduction + performance improvements)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants