Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Token Network Filter UI [Mobile] #11808

Draft
wants to merge 58 commits into
base: main
Choose a base branch
from
Draft

feat: Token Network Filter UI [Mobile] #11808

wants to merge 58 commits into from
+1,216 −852

Conversation

gambinish
Copy link
Contributor

Description

Introduces Token Networking filtering. This is a WIP draft.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

gambinish and others added 30 commits September 26, 2024 17:09
@gambinish
feat: Add sortAssets utility function
0248c74
@gambinish
chore: Breakup monolithic Tokens/index.tsx into smaller components
6a2e8c7
@gambinish
fix: Correctly handle null check for buyable footer button
7a78717
@gambinish
fix: Tweak boolean logic for rendering footer components
57295ee
@gambinish
chore: Update snapshot
d00354f
@gambinish
chore: Type out tokens as TokenI[]
be87f81
@gambinish
chore: Remove unecessary comments around import statements in Networt…
68c7b2e 
…h component
@gambinish
Merge branch 'main' into chore/componetize-tokens-screen
a02e139
@gambinish
Merge branch 'main' into chore/componetize-tokens-screen
de5bbed
@gambinish
Merge branch 'main' into chore/componetize-tokens-screen
0fd9ad5
@gambinish
chore: Add unit tests to utility file, provide exports from index file
032618c
@gambinish
chore: Rename handleBalance to me more descriptive of what its logic …
a58f1ba 
…is handling
@gambinish
chore: rename Networth to PortfolioBalance for clarity
1dd31e3
@gambinish
chore: Cleanup styles extra whitespace
16ded6a
@gambinish
Merge branch 'main' into chore/componetize-tokens-screen
52d3d85
@gambinish
fix: Update snapshot tests
dd3ffdf
@gambinish
Merge branch 'chore/componetize-tokens-screen' of github.com:MetaMask…
da640bc 
…/metamask-mobile into chore/componetize-tokens-screen
@gambinish
fix: Remove unused component
ebcbcf6
@gambinish
Merge branch 'main' into chore/componetize-tokens-screen
31fad19
@gambinish
chore: Move PotfolioBalance above TabView
4a8d927
@gambinish
fix: Wrap PortfolioBalance and ScrollableView in fragment for token r…
a7b4c17 
…endering
@gambinish
fix: Padding tweak below tab bar for consistency of token list
658fcf6
@gambinish
fix: Reorganize test suite for PortfolioBalance
18035d4
@gambinish
fix: Revert changes to wallet test
c570c2c
@gambinish
fix: Update fiatBalance text style to DisplayMD
a97128b
@gambinish
chore: Patch PreferencesController with tokenSortConfig
8036a0a
@gambinish
chore: Patch preferences controller with type
1f0ac51
@gambinish
feat: Build token sorting UI, patch PreferencesController
34d987c
@gambinish
chore: Merge main, address merge conflicts
d57558b
@gambinish
fix: ListHeaderComponent not needed in FlatList anymore
c5c954c
gambinish and others added 22 commits October 10, 2024 11:38
@gambinish
fix: Declning balance sort
2890148
@gambinish
fix: Export raw value from deriveBalanceFromAssetMarketDetails
25a7238
@gambinish
fix: deriveBalanceFromAssetMarketDetails.test.ts
6637303
@gambinish
fix: Update unit tests and snapshots
0415b73
@gambinish
fix: Lint unused imports from Tokens/index.tsx
ff32cc4
@gambinish
chore: Update testIds and locale strings
f4f2519
@gambinish
fix: Update WalletView import selector
bd61eff
@gambinish
fix: Update snapshots
f28b6fe
@gambinish
chore: Cleanup
7c9d5cc
@gambinish
fix: Add navigation type
e747848
@salimtb
fix: fix snapshot
71ce22f
@salimtb
Merge branch 'main' into feat/mmassets_357-sort-import-tokens-mobile-…
6aa6f3f 
…-reorg-portfolio-balance
@gambinish
chore: Update snapshots
fe21f40
@gambinish
Merge branch 'feat/mmassets_357-sort-import-tokens-mobile--reorg-port…
6f52163 
…folio-balance' into feat/mmassets_357-sort-import-tokens-mobile--token-sort-config
@gambinish
fix: Update placeholders in switch statement
579f012
@gambinish
Merge branch 'feat/mmassets_357-sort-import-tokens-mobile--token-sort…
68338a3 
…-config' of github.com:MetaMask/metamask-mobile into feat/mmassets_357-sort-import-tokens-mobile--token-sort-config
@gambinish
chore: Add additional e2e test for import token footer link
ff95c72
@gambinish
chore: Update snapshots
1d929ce
@gambinish
chore: Patch PreferencesController with tokenNetworkFilter
9cf6337
@gambinish
fix: Update to correct type in PreferenceController patch
fcf0d64
@gambinish
fix: Correct method name in patched PreferenceController
e3196a3
@gambinish
chore: Integrate Filter dropdown with PreferencesController
aa5b6da
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish changed the base branch from main to feat/mmassets_357-sort-import-tokens-mobile--token-sort-config October 16, 2024 01:49
@gambinish gambinish changed the title feat: Token Network Filter UI feat: Token Network Filter UI [Extension] Oct 16, 2024
@gambinish gambinish changed the title feat: Token Network Filter UI [Extension] feat: Token Network Filter UI [Mobile] Oct 16, 2024
@gambinish
Copy link
Contributor Author

WIP recording:

Screen.Recording.2024-10-17.at.8.04.31.AM.mov

Base automatically changed from feat/mmassets_357-sort-import-tokens-mobile--token-sort-config to main October 22, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonybur jonybur Awaiting requested review from jonybur

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
team-assets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gambinish @salimtb