-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds useChainId
components views
#11813
Open
andreahaku
wants to merge
7
commits into
feature/adds_useChainId_components_hooks
Choose a base branch
from
feature/adds_useChainId_components_views
base: feature/adds_useChainId_components_hooks
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: adds useChainId
components views
#11813
andreahaku
wants to merge
7
commits into
feature/adds_useChainId_components_hooks
from
feature/adds_useChainId_components_views
+20
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreahaku
changed the title
Feature/adds use chain id components views
feat: adds use chain id components views
Oct 17, 2024
andreahaku
changed the base branch from
feat/preparation_for_asset_chainId
to
feature/adds_useChainId_components_hooks
October 17, 2024 13:03
…adds_useChainId_components_views
andreahaku
changed the title
feat: adds use chain id components views
feat: adds Oct 21, 2024
useChainId
components views
This was referenced Oct 21, 2024
andreahaku
added
Code Impact - Low
Minor code change that can safely applied to the codebase
Priority - Low
Task with low priority
Run Smoke E2E
Triggers smoke e2e on Bitrise
labels
Oct 21, 2024
Bitrise❌❌❌ Commit hash: dae7218 Note
Tip
|
andreahaku
added
Priority - Medium
Task with medium priority
and removed
Priority - Low
Task with low priority
labels
Oct 21, 2024
…adds_useChainId_components_views
…adds_useChainId_components_views
…adds_useChainId_components_views
…adds_useChainId_components_views
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Code Impact - Low
Minor code change that can safely applied to the codebase
Priority - Medium
Task with medium priority
Run Smoke E2E
Triggers smoke e2e on Bitrise
team-wallet-ux
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for
useChainId
hook to components ViewsRelated issues
Fixes: https://github.com/orgs/MetaMask/projects/85/views/2?pane=issue&itemId=82943990
Related PRs
useChainId
hook) #11753useChainId
to more token/nft components #11781useChainId
to components hooks #11811useChainId
components views #11813 (this one)useChainId
hook to all other UI components #11837Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist