Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds useChainId components views #11813

Open
wants to merge 7 commits into
base: feature/adds_useChainId_components_hooks
Choose a base branch
from

Conversation

andreahaku
Copy link
Member

@andreahaku andreahaku commented Oct 16, 2024

Description

Adds support for useChainId hook to components Views

Related issues

Fixes: https://github.com/orgs/MetaMask/projects/85/views/2?pane=issue&itemId=82943990

Related PRs

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions github-actions bot added the team-sdk SDK team label Oct 16, 2024
@andreahaku andreahaku added team-wallet-ux and removed team-sdk SDK team labels Oct 16, 2024
@andreahaku andreahaku changed the title Feature/adds use chain id components views feat: adds use chain id components views Oct 17, 2024
@andreahaku andreahaku changed the base branch from feat/preparation_for_asset_chainId to feature/adds_useChainId_components_hooks October 17, 2024 13:03
@andreahaku andreahaku marked this pull request as ready for review October 21, 2024 12:59
@andreahaku andreahaku requested review from a team as code owners October 21, 2024 12:59
@andreahaku andreahaku added Code Impact - Low Minor code change that can safely applied to the codebase Priority - Low Task with low priority Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 21, 2024
Copy link
Contributor

github-actions bot commented Oct 21, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: dae7218
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/46a0170f-9805-4bb8-bf5d-e403a6d8f4d3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@andreahaku andreahaku added Priority - Medium Task with medium priority and removed Priority - Low Task with low priority labels Oct 21, 2024
Copy link

sonarcloud bot commented Oct 22, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Impact - Low Minor code change that can safely applied to the codebase Priority - Medium Task with medium priority Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant