feat(3481): overflow update #11823

vinnyhoward · 2024-10-16T18:05:32Z

Description

The overflow UI is being updated as part of a bigger redesign for the header

Part of this design is the removal of the WalletAccount component. It will no longer be used and can probably be removed. I will confirm and create a follow up PR to remove it.

The WalletAccount component will no longer be used and can probably be removed. I will confirm and create a follow up PR. Because WalletAccount is being removed, the more icon or overflow icon will be moved to the AccountSelectorList. Here is the Figma design

NOTE: This is being merged into my feat-header-update branch and NOT main

Related issues

Feature: #3481

Manual testing steps

Open the wallet homepage.
Tap the account picker to open the bottom sheet.
In the bottom sheet, verify the following for the selected account:
- Edit the account name and confirm changes are saved.
- Check that tapping "View on Etherscan" opens the correct page.
- Use "Share address" and confirm the correct address is shared.
- Verify the correct private key is displayed
If multiple accounts exist:
- Switch between accounts and repeat step 3 for each.
Check overall UI
Verify smooth animations and proper styling.

Changes to `RevealPrivateCredential` component

It now accepts selectedAddress as params to accommodate for the new UI changes. If the params doesn't exist it will fallback to the the selected account that is fetched from the account controller

Select your account
Goto settings from the bottom right icon
Click on "Security & Privacy"
Click on the "Reveal Secret Recovery Phrase" button and go through the flow and verify that is your correct private key

Screenshots/Recordings

Edit Account

Light	Dark

Etherscan

Light	Dark

Before

WIP

After

WIP

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…3481-header-update-overflow

github-actions · 2024-10-16T18:05:44Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions · 2024-10-16T18:06:10Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8a3c142
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7c43ec5d-c070-4a21-8887-89c551bc7992

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

…ile into feat-3481-header-update-overflow

…passed from params to accomdate for new ui changes

…ile into feat-3481-header-update-overflow

github-actions · 2024-10-17T00:25:26Z

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 51fb3fc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/31bff964-2244-49d6-b848-cfcdfd5bdd93

Note

This comment will auto-update when build completes
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

codecov-commenter · 2024-10-17T00:34:52Z

Codecov Report

Attention: Patch coverage is 68.75000% with 10 lines in your changes missing coverage. Please review.

Please upload report for BASE (feat-header-update@65df76f). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...nts/UI/AccountSelectorList/AccountSelectorList.tsx	66.66%	3 Missing and 1 partial ⚠️
.../components/List/ListItemSelect/ListItemSelect.tsx	57.14%	2 Missing and 1 partial ⚠️
...mponents/Views/EditAccountName/EditAccountName.tsx	62.50%	0 Missing and 3 partials ⚠️

Additional details and impacted files

@@                  Coverage Diff                  @@
##             feat-header-update   #11823   +/-   ##
=====================================================
  Coverage                      ?   54.50%           
=====================================================
  Files                         ?     1737           
  Lines                         ?    39274           
  Branches                      ?     4866           
=====================================================
  Hits                          ?    21407           
  Misses                        ?    16377           
  Partials                      ?     1490

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-10-17T00:41:10Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 953ba82
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c1d786ee-56d5-48fe-bd0a-9698ddcda348

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

…ile into feat-3481-header-update-overflow

github-actions · 2024-10-17T18:46:16Z

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 5a64f40
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3e8c1784-ba3a-481f-893a-0ba6ce59abd7

Note

This comment will auto-update when build completes
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

…ile into feat-3481-header-update-overflow

github-actions · 2024-10-18T17:47:55Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4ec927c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0d567897-e913-4844-a777-0cc853350752

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-10-18T18:57:48Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e3bcf42
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c770502b-8efb-4f13-a951-34481303e497

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

…hat suited my needs

…k/metamask-mobile into feat-3481-header-update-overflow

github-actions · 2024-10-19T21:46:18Z

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: be7612b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/994896cc-f3d9-42b4-be2a-2d68ee1c24f3

Note

This comment will auto-update when build completes
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

vinnyhoward · 2024-10-19T21:46:57Z

app/components/Nav/App/index.js

@@ -912,7 +906,7 @@ const App = (props) => {
          <Stack.Screen name={Routes.OPTIONS_SHEET} component={OptionsSheet} />
          <Stack.Screen
            name="EditAccountName"
-            component={EditAccountNameFlow}


This is needed so that EditAccountNameFlow can access params being passed

github-actions · 2024-10-19T22:06:36Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7f1916f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b63ae2b1-7ee6-4c32-b2bc-c0eb153da5ac

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions · 2024-10-21T21:40:44Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 24ac953
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f95b5ce5-4f47-419e-ad47-07e80ecb6ff4

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarcloud · 2024-10-21T21:50:43Z

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
77.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

vinnyhoward added 2 commits October 16, 2024 11:58

update: match overlow UI with figma design

d65b339

Merge branch 'main' of github.com:MetaMask/metamask-mobile into feat-…

8a3c142

…3481-header-update-overflow

vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux area-qa Relating to QA work (Quality Assurance) labels Oct 16, 2024

vinnyhoward added 3 commits October 16, 2024 12:07

Merge branch 'feat-header-update' of github.com:MetaMask/metamask-mob…

5861a06

…ile into feat-3481-header-update-overflow

update: account action logic now relies on or extends from addresses …

1b8e370

…passed from params to accomdate for new ui changes

Merge branch 'feat-header-update' of github.com:MetaMask/metamask-mob…

51fb3fc

…ile into feat-3481-header-update-overflow

vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 17, 2024

fix: lint type issue

953ba82

vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 17, 2024

Merge branch 'feat-header-update' of github.com:MetaMask/metamask-mob…

c32286c

…ile into feat-3481-header-update-overflow

vinnyhoward mentioned this pull request Oct 17, 2024

feat(3448): header update #11763

Open

7 tasks

Merge branch 'feat-header-update' of github.com:MetaMask/metamask-mob…

5a64f40

…ile into feat-3481-header-update-overflow

vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 17, 2024

Merge branch 'feat-header-update' of github.com:MetaMask/metamask-mob…

6b8aeed

…ile into feat-3481-header-update-overflow

vinnyhoward removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 17, 2024

vinnyhoward requested review from a team as code owners October 17, 2024 19:25

Merge branch 'feat-header-update' into feat-3481-header-update-overflow

4ec927c

vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 18, 2024

Merge branch 'feat-header-update' into feat-3481-header-update-overflow

e3bcf42

vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 18, 2024

merge branch from feat-header-update

ea99592

vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 18, 2024

vinnyhoward added 3 commits October 18, 2024 16:46

Merge branch 'feat-header-update' into feat-3481-header-update-overflow

ffd4e45

fix: reverted changes to component libs because a component existed t…

10fc773

…hat suited my needs

Merge branch 'feat-3481-header-update-overflow' of github.com:MetaMas…

be7612b

…k/metamask-mobile into feat-3481-header-update-overflow

vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 19, 2024

vinnyhoward commented Oct 19, 2024

View reviewed changes

fix: more reverts for unneeded changes

7f1916f

vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 19, 2024

Merge branch 'feat-header-update' into feat-3481-header-update-overflow

24ac953

vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(3481): overflow update #11823

feat(3481): overflow update #11823

vinnyhoward commented Oct 16, 2024 •

edited

Loading

github-actions bot commented Oct 16, 2024

github-actions bot commented Oct 16, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 17, 2024

codecov-commenter commented Oct 17, 2024

github-actions bot commented Oct 17, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Oct 18, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 18, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 19, 2024

vinnyhoward Oct 19, 2024

github-actions bot commented Oct 19, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 21, 2024 •

edited by metamaskbot

Loading

sonarcloud bot commented Oct 21, 2024

feat(3481): overflow update #11823

Are you sure you want to change the base?

feat(3481): overflow update #11823

Conversation

vinnyhoward commented Oct 16, 2024 • edited Loading

Description

Related issues

Manual testing steps

Changes to RevealPrivateCredential component

Screenshots/Recordings

Edit Account

Etherscan

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Oct 16, 2024

github-actions bot commented Oct 16, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Oct 17, 2024

Bitrise

codecov-commenter commented Oct 17, 2024

Codecov Report

github-actions bot commented Oct 17, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Oct 17, 2024 • edited Loading

Bitrise

github-actions bot commented Oct 18, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Oct 18, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Oct 19, 2024

Bitrise

vinnyhoward Oct 19, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 19, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Oct 21, 2024 • edited by metamaskbot Loading

Bitrise

sonarcloud bot commented Oct 21, 2024

Quality Gate passed

vinnyhoward commented Oct 16, 2024 •

edited

Loading

Changes to `RevealPrivateCredential` component

github-actions bot commented Oct 16, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 17, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Oct 18, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 18, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 19, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 21, 2024 •

edited by metamaskbot

Loading