Stake 806 to uat #11912

siibars · 2024-10-21T12:37:18Z

Description

PR from this one onto a uat branch so that we can create a QA release from it.

Related issues

Fixes: stake-806

Manual testing steps

When merged get the apk built from the test/mobile-staking-uat branch and test it on your device.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

The stakeSdkProvider component has been updated to use the new stakingApiService from the @metamask/stake-sdk library.

…keProvider

- Added usePooledStakes hook to fetch pooled stakes data from the staking API service - Added useStakingChain hook to check if the current chain is supported for staking - Added useStakingEligibility hook to fetch staking eligibility data from the staking API service - Added useVaultData hook to fetch vault data from the staking API service These hooks provide the necessary functionality for staking operations and data retrieval in the UI.

…data

…lation

This commit adds a new hook called useStakingEarnings to calculate staking earnings. The hook utilizes the useVaultData, useBalance, and usePooledStakes hooks to fetch necessary data and perform calculations. It calculates the lifetime rewards in ETH and fiat, as well as the estimated annual earnings in ETH and fiat.

…lculation

…ng skeleton

…rds display

… hook

…nd reward data

….tsx

github-actions · 2024-10-21T12:37:32Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2024-10-21T12:37:37Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/stake-sdk@0.2.13	network	`0`	165 kB	metamaskbot
npm/follow-redirects@1.15.9	network	`0`	29.9 kB	rubenverborgh
npm/form-data@4.0.1	filesystem, network	`0`	31.4 kB	ljharb

🚮 Removed packages: npm/@metamask/stake-sdk@0.2.11

View full report↗︎

socket-security · 2024-10-21T12:37:38Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/follow-redirects@1.15.9, npm/form-data@4.0.1, npm/@metamask/stake-sdk@0.2.13

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

siibars · 2024-10-21T12:45:17Z

@SocketSecurity ignore-all

@metamask/Stake-sdk uses fetch to communicate with staking backend api service

sonarcloud · 2024-10-21T12:49:47Z

Please retry analysis of this Pull-Request directly on SonarCloud

amitabh94 added 30 commits October 18, 2024 11:48

refactor: move StakingEarnings component to the stake directory

d87feb9

chore: update @metamask/stake-sdk to version 0.2.13

7eb54c5

feat: update stakeSdkProvider to use new stakingApiService

e846731

The stakeSdkProvider component has been updated to use the new stakingApiService from the @metamask/stake-sdk library.

refactor: update useStakeContext to throw error when used outside Sta…

f2abb3c

…keProvider

feat: update StakingBalance component to replace mock data

977f412

feat: update StakingEarnings component to use new hooks and provider

308ccde

feat: remove unused useGetStakingEligibility hook and stakingApi slice

1eaec86

refactor: update StakeInputView to use new hooks and remove unused code

eec754f

refactor: update import path for mock data in StakeConfirmationView

9c89a9c

refactor: update UnstakeInputView.test.tsx to use new hooks and mock …

322c531

…data

feat: update StakeButton to use new hooks and provider

d512b3f

feat: update TokenListItem to use new hooks for staking

0c690b4

Merge branch 'main' into STAKE-806--fe-integrate-stake-and-vault-data

4279ff1

feat: update usePooledStakes hook to include additional status checks

10dc9eb

refactor: rename useIsStakingSupportedChain to useStakingChain

2f2dced

refactor: remove unused code in useStakingEligibility hook

b4d6418

refactor: optimize useVaultData hook and add annual reward rate calcu…

44ab8f5

…lation

refactor: optimize useBalance hook and add staked balance calculations

8679a78

refactor: optimize useStakingInput hook and improve annual rewards ca…

7a434e0

…lculation

feat: replace staking earnings mock data with api data

ef56ed6

feat: add staking earnings mock data

df271c6

refactor: optimize EstimatedAnnualRewardsCard component and add loadi…

ef32a7e

…ng skeleton

feat: replace staking mocked asset data with actual values

1367151

refactor: remove unused state and optimize TokenDetails component

0de4d3d

refactor: optimize StakingButtons component and update props

8a4409e

refactor: update reward rate display in RewardsCard component

631f14a

chore: update stake provider snapshot

c7e08a4

feat: update UnstakeInputView component and use actual staked balance

d23bd5e

amitabh94 and others added 6 commits October 20, 2024 21:38

refactor: update StakeInputView component and optimize estimated rewa…

945fa26

…rds display

refactor: update TokenListItem component to use updated staking chain…

79c8e68

… hook

refactor: update StakeConfirmationView to use actual staked balance a…

ae15965

…nd reward data

refactor: move stake button component to stake directory

efb787c

refactor: update import path for Theme type in StakingEarnings.styles…

e408753

….tsx

Merge branch 'main' into STAKE-806--fe-integrate-stake-and-vault-data

577ae6b

Merge branch 'test/mobile-staking-uat' into stake-806-to-uat

68dd36e

siibars marked this pull request as ready for review October 21, 2024 12:40

siibars requested review from a team as code owners October 21, 2024 12:40

siibars added the team-stake label Oct 21, 2024

siibars merged commit ced542a into test/mobile-staking-uat Oct 21, 2024
42 checks passed

siibars deleted the stake-806-to-uat branch October 21, 2024 13:16

github-actions bot locked and limited conversation to collaborators Oct 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stake 806 to uat #11912

Stake 806 to uat #11912

siibars commented Oct 21, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024

socket-security bot commented Oct 21, 2024 •

edited

Loading

socket-security bot commented Oct 21, 2024 •

edited

Loading

siibars commented Oct 21, 2024

sonarcloud bot commented Oct 21, 2024

Stake 806 to uat #11912

Stake 806 to uat #11912

Conversation

siibars commented Oct 21, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Oct 21, 2024

socket-security bot commented Oct 21, 2024 • edited Loading

socket-security bot commented Oct 21, 2024 • edited Loading

Next steps

siibars commented Oct 21, 2024

sonarcloud bot commented Oct 21, 2024

siibars commented Oct 21, 2024 •

edited

Loading

socket-security bot commented Oct 21, 2024 •

edited

Loading

socket-security bot commented Oct 21, 2024 •

edited

Loading