Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update attributions #11922

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

NicolasMassart
Copy link
Contributor

Description

Update attribution

Related issues

Fixes the CI failing on release 7.33.0 branch

Manual testing steps

N/A

Screenshots/Recordings

N/A

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NicolasMassart NicolasMassart requested a review from a team as a code owner October 21, 2024 16:30
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Oct 21, 2024

@NicolasMassart NicolasMassart added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E Triggers smoke e2e on Bitrise and removed team-mobile-platform labels Oct 21, 2024
Copy link
Contributor

github-actions bot commented Oct 21, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e836d8c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/72a0316f-8b5e-4650-a5d3-a9b655064cd2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@NicolasMassart NicolasMassart self-assigned this Oct 21, 2024
@NicolasMassart NicolasMassart changed the title update attributions chore: update attributions Oct 21, 2024
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NicolasMassart NicolasMassart merged commit 5d66db4 into release/7.33.0 Oct 22, 2024
45 checks passed
@NicolasMassart NicolasMassart deleted the chore/update_attributions branch October 22, 2024 08:07
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants