Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new default networks #11926

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Oct 21, 2024

Description

This PR ensures that a predefined list of popular networks (Arbitrum, BSC, Base, Optimism, and Polygon) is automatically added for new users only during the app startup process. The networks are added using NetworkController.addNetwork within the useEffect hook inside the app's initialization flow.

Related issues

Fixes:

Manual testing steps

  1. Do a new fresh install app
  2. Import/create your wallet
  3. check the list of added networks

Screenshots/Recordings

Before

Screenshot 2024-10-21 at 20 02 38

After

Screenshot 2024-10-21 at 19 56 59

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb added team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Oct 21, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb changed the title Salim/add new default networks feat: add new default networks Oct 21, 2024
@salimtb salimtb force-pushed the salim/add-new-default-networks branch from ca47c0e to cdf1c3d Compare October 21, 2024 17:46
@salimtb salimtb force-pushed the salim/add-new-default-networks branch from cdf1c3d to 644a541 Compare October 21, 2024 17:51
Copy link

sonarcloud bot commented Oct 21, 2024

@salimtb salimtb added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 21, 2024
Copy link
Contributor

github-actions bot commented Oct 21, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 644a541
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/68cbb283-a36e-4d51-9ac3-7e67ef74c200

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant