Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Refactor Advanced Gas fees test to utilize mocks #11927

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

test: Refactor Advanced Gas fees test to utilize mocks #11927

wants to merge 30 commits into from
+112 −31

Conversation

SamuelSalas
Copy link
Member

Description

The advanced gas fees tests are becoming a bit unstable within the smoke pipeline mainly because we are relying on real funds (Sepolia ETH) to submit the transaction. With the recent addition of mocking, we should refactor the advanced gas fees tests to:

  • use ganache
  • mock the gas api to return expected values

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

SamuelSalas and others added 27 commits October 9, 2024 18:31
@SamuelSalas
Mock suggestedGasApi to display the EIP1559 edit priority modal
80168ab
@SamuelSalas
Merge branch 'main' into e2e/11606-refactor-advanced-gas-fees-test-mocks
07ceac6
@SamuelSalas
Update snapshot
71497ae
@SamuelSalas
Merge branch 'main' into e2e/11606-refactor-advanced-gas-fees-test-mocks
a0cafef
@SamuelSalas
Merge branch 'main' into e2e/11606-refactor-advanced-gas-fees-test-mocks
f2b3544
@SamuelSalas
Merge branch 'main' into e2e/11606-refactor-advanced-gas-fees-test-mocks
c54dcb8
@SamuelSalas
Change beforeall
126eab7
@SamuelSalas
Merge branch 'main' into e2e/11606-refactor-advanced-gas-fees-test-mocks
851a9fb
@SamuelSalas
Merge branch 'main' into e2e/11606-refactor-advanced-gas-fees-test-mocks
9edfc24
@SamuelSalas
Merge branch 'main' into e2e/11606-refactor-advanced-gas-fees-test-mocks
27f4ac4
@SamuelSalas
Update mockttp default port
36d298e
@SamuelSalas
Merge branch 'main' into e2e/11606-refactor-advanced-gas-fees-test-mocks
2606fb6
@SamuelSalas
Unify mockttp url
35f765a
@SamuelSalas
Expose mock server port
e5d1e62
@SamuelSalas
Merge branch 'main' into e2e/11606-refactor-advanced-gas-fees-test-mocks
6e28a7d
@SamuelSalas
Add portfinder to check that mockport is available
ad3d5b1
@SamuelSalas
Merge branch 'main' into e2e/11606-refactor-advanced-gas-fees-test-mocks
bbd8504
@SamuelSalas
Merge branch 'main' into e2e/11606-refactor-advanced-gas-fees-test-mocks
96ec958
@SamuelSalas
Add mockPort const
fbc5d32
@SamuelSalas
Only run confirmations on android
2d118bd
@SamuelSalas
Merge branch 'main' into e2e/11606-refactor-advanced-gas-fees-test-mocks
fe8c361
@Andepande
added loggin and small modifications
c92bc11
@Andepande
Update mockServer.js
390347f
@Andepande
Merge branch 'main' into modify-mockserver-for-android
f319d82
@Andepande
small change
fcb151c
@SamuelSalas
Merge branch 'main' into modify-mockserver-for-android
aff2a1a
@SamuelSalas
Make the othr workflows available for bitrise
55bb507
@SamuelSalas SamuelSalas requested review from a team as code owners October 21, 2024 18:59
@SamuelSalas SamuelSalas self-assigned this Oct 21, 2024
@SamuelSalas SamuelSalas added Run Smoke E2E Triggers smoke e2e on Bitrise Detox labels Oct 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 55bb507
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/37a986e5-50c5-4672-b317-c0e510916377

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

cortisiko
cortisiko requested changes Oct 21, 2024
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice stuff! small feedback

e2e/pages/Send/AmountView.js

class AmountView {
get currencySwitch() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recall we had a specific use case for this. Unfortunately, the test that used this test step was deleted

metamask-mobile/e2e/specs/confirmations/send-eth-flow.spec.js

Line 58 in 3635e72

await AmountView.tapCurrencySwitch();
. We can work to add it back. Do not remove.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

e2e/pages/Send/AmountView.js Outdated
@@ -26,9 +29,5 @@ class AmountView {
? await Gestures.typeTextAndHideKeyboard(this.amountInputField, amount)
: await Gestures.replaceTextInField(this.amountInputField, amount);
}

async tapCurrencySwitch() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recall we had a specific use case for this. Unfortunately, the test that used this test step was deleted

metamask-mobile/e2e/specs/confirmations/send-eth-flow.spec.js

Line 58 in 3635e72

await AmountView.tapCurrencySwitch();
. We can work to add it back. Do not remove.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@SamuelSalas SamuelSalas requested a review from a team as a code owner October 21, 2024 20:44
@SamuelSalas SamuelSalas added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 48520e2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9075e9d2-3ff0-4950-8917-8e8a495bb74d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortisiko cortisiko cortisiko requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@SamuelSalas SamuelSalas

Labels
Detox Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SamuelSalas @cortisiko @Andepande