fix: replace legacy eth-json-rpc deps

[legobeat]

Description

• This PR is a rebase of chore: Update json-rpc-provider & json-rpc-middleware & json-rpc-filters #10098, including:
  • Add @metamask/eth-json-rpc-middleware  #9925
  • feat: [WIP] Test #9274 + #9925 #9930
• Bump @metamask/eth-json-rpc-filters to ^7.0.0
• Bump @metamask/json-rpc-engine to ^10.0.0
• Bump @metamask/eth-json-rpc-middleware to >=12.0.0
• Revert Internal JSON-RPC error message change to accomodate for @metamask/rpc-errors v7

Related issues

Blocked by

• chore: nodejs 20.18.0 #11953

Manual testing steps

1. Go to in-app browser
2. Test connect with multiple dapps
3. Perform transaciton on test dapp
4. Go to this page...

Screenshots/Recordings

Screen.Recording.2024-06-24.at.22.46.41.mov

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/eth-json-rpc-filters@9.0.0	None	+2	372 kB	lgbot
npm/@metamask/eth-json-rpc-provider@4.1.5	None	0	56.8 kB	danfinlay, gudahtt, kumavis, ...8 more
npm/ethereumjs-abi@0.6.6	None	+2	974 kB	holgerd77

🚮 Removed packages: npm/@metamask/eth-json-rpc-provider@4.1.4, npm/btoa@1.2.1, npm/checkpoint-store@1.1.0, npm/clone@2.1.2, npm/deferred-leveldown@1.2.2, npm/eth-json-rpc-errors@1.1.1, npm/eth-json-rpc-filters@4.2.2, npm/eth-json-rpc-middleware@6.0.0, npm/eth-query@2.1.2, npm/eth-rpc-errors@3.0.0, npm/eth-sig-util@1.4.2, npm/ethereum-common@0.2.0, npm/ethereumjs-abi@0.6.8, npm/ethereumjs-account@2.0.5, npm/ethereumjs-block@1.7.1, npm/ethereumjs-tx@1.3.7, npm/ethereumjs-vm@2.6.0, npm/fake-merkle-patricia-tree@1.0.1, npm/fetch-ponyfill@4.1.0, npm/json-stable-stringify@1.0.1, npm/jsonify@0.0.0, npm/level-codec@7.0.1, npm/level-errors@1.0.5, npm/level-iterator-stream@1.3.1, npm/level-ws@0.0.0, npm/levelup@1.3.9, npm/memdown@1.4.1, npm/merkle-patricia-tree@2.3.2, npm/rustbn.js@0.2.0, npm/safe-event-emitter@1.0.1, npm/semaphore@1.1.0

View full report↗︎

[socket-security]

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note	Source	CI
New author	npm/ethereumjs-abi@0.6.6	New Author: holgerd77 Previous Author: axic	package.json yarn.lock	🚫

View full report↗︎

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

• @SocketSecurity ignore npm/ethereumjs-abi@0.6.6

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8dbb040
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3ad83a50-aa8c-41b5-b2d1-4f03f2a08097

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
76.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[tommasini]

😍😍😍😍😍😍