chore: Convert browser tab to typescript #12740

tommasini · 2024-12-17T20:45:14Z

Description

Refactor of browser tab to typescript

Please visit this issue that includes a bigger description: https://github.com/MetaMask/mobile-planning/issues/2087

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-12-17T20:45:28Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions · 2024-12-17T20:45:43Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f0c5d88
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ceff49dc-61ee-4d5b-8b25-0fc07a21ff21

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

…mask-mobile into fix/browser-tab-convert-ts

github-actions · 2024-12-18T22:41:04Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e150c07
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/07b53de9-226e-462d-9044-fb8f9aab13c9

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

codecov-commenter · 2024-12-18T23:02:45Z

Codecov Report

Attention: Patch coverage is 42.66667% with 430 lines in your changes missing coverage. Please review.

Project coverage is 60.54%. Comparing base (8dacf7b) to head (9053522).
Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
app/components/Views/BrowserTab/BrowserTab.tsx	27.41%	308 Missing and 7 partials ⚠️
...ents/Views/BrowserTab/components/Options/index.tsx	40.98%	33 Missing and 3 partials ⚠️
app/components/UI/UrlAutocomplete/index.tsx	57.14%	17 Missing and 1 partial ⚠️
...iews/BrowserTab/components/PhishingModal/index.tsx	34.61%	17 Missing ⚠️
app/components/Views/BrowserTab/styles.ts	35.29%	4 Missing and 7 partials ⚠️
app/components/UI/BrowserUrlBar/BrowserUrlBar.tsx	84.37%	8 Missing and 2 partials ⚠️
app/components/Views/Browser/index.js	0.00%	8 Missing ⚠️
...rs/Avatar/variants/AvatarFavicon/AvatarFavicon.tsx	85.71%	1 Missing and 1 partial ⚠️
app/components/UI/DeleteWalletModal/index.tsx	50.00%	2 Missing ⚠️
app/components/Views/AssetOptions/AssetOptions.tsx	0.00%	2 Missing ⚠️
... and 8 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #12740      +/-   ##
==========================================
+ Coverage   60.06%   60.54%   +0.47%     
==========================================
  Files        1900     1910      +10     
  Lines       42513    42637     +124     
  Branches     5612     5731     +119     
==========================================
+ Hits        25536    25813     +277     
+ Misses      15250    15072     -178     
- Partials     1727     1752      +25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2025-01-23T00:12:53Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c3442b7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/321a2656-e200-4038-98a5-578b6da1954b

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions · 2025-01-23T00:59:36Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9053522
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3a6c494d-ee55-4c21-bd0d-958b3ba75b82

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions · 2025-01-23T11:29:27Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: be33a09
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1c5ea816-bee3-400b-9595-bdeeba12c130

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarqubecloud · 2025-01-23T11:39:57Z

Quality Gate passed

Issues
32 New issues
0 Accepted issues

Measures
0 Security Hotspots
72.3% Coverage on New Code
4.0% Duplication on New Code

See analysis details on SonarQube Cloud

EtherWizard33

re-approve after prev was reset

christopherferreira9

re-approve from @abretonc7s 's

Convert browser tab to typescript

f0c5d88

tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 17, 2024

tommasini requested review from a team as code owners December 17, 2024 20:45

tommasini marked this pull request as draft December 17, 2024 20:45

tommasini and others added 12 commits December 17, 2024 21:06

fix snapshot

cbdca18

fix snapshot

ca3e7d4

Abstract types, consts, and styles

805f954

Merge branch 'fix/browser-tab-convert-ts' of github.com:MetaMask/meta…

4173703

…mask-mobile into fix/browser-tab-convert-ts

Store original browser tab in BrowserTab file

e50280f

Create simplified webview that prevents spoofing issues

ce3f381

Clean up code

a483b90

Also handle spoof scenarios for Android

f83509c

small fix, import react on simple webview

f62820a

Merge branch 'fix/browser-tab-convert-ts' of github.com:MetaMask/meta…

765a24a

…mask-mobile into fix/browser-tab-convert-ts

types and eslint browser tab final version

50c8db6

Merge branch 'main' into fix/browser-tab-convert-ts

e150c07

tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 18, 2024

update browser tab utils Url variable name

f9dee5a

tommasini marked this pull request as ready for review December 18, 2024 22:55

tommasini requested a review from a team as a code owner December 18, 2024 22:55

Cal-L added 2 commits December 19, 2024 00:26

Replace browser tab input

c9eb384

Handle condition where load ends with same origins

0f074f5

tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 22, 2025

Merge branch 'main' into fix/browser-tab-convert-ts

c3442b7

tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 23, 2025

Merge branch 'main' into fix/browser-tab-convert-ts

9053522

tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 23, 2025

Merge branch 'main' into fix/browser-tab-convert-ts

be33a09

tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 23, 2025

EtherWizard33 self-requested a review January 23, 2025 15:07

EtherWizard33 approved these changes Jan 23, 2025

View reviewed changes

adonesky1 approved these changes Jan 23, 2025

View reviewed changes

sahar-fehri approved these changes Jan 23, 2025

View reviewed changes

christopherferreira9 approved these changes Jan 23, 2025

View reviewed changes

brianacnguyen approved these changes Jan 23, 2025

View reviewed changes

tommasini added this pull request to the merge queue Jan 23, 2025

Merged via the queue into main with commit e046eb6 Jan 23, 2025
46 checks passed

tommasini deleted the fix/browser-tab-convert-ts branch January 23, 2025 18:25

github-actions bot locked and limited conversation to collaborators Jan 23, 2025

github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 23, 2025

metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Convert browser tab to typescript #12740

chore: Convert browser tab to typescript #12740

tommasini commented Dec 17, 2024 •

edited

Loading

github-actions bot commented Dec 17, 2024

github-actions bot commented Dec 17, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Dec 18, 2024 •

edited by metamaskbot

Loading

codecov-commenter commented Dec 18, 2024 •

edited

Loading

github-actions bot commented Jan 23, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Jan 23, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Jan 23, 2025 •

edited by metamaskbot

Loading

sonarqubecloud bot commented Jan 23, 2025

EtherWizard33 left a comment

christopherferreira9 left a comment

chore: Convert browser tab to typescript #12740

chore: Convert browser tab to typescript #12740

Conversation

tommasini commented Dec 17, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Dec 17, 2024

github-actions bot commented Dec 17, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Dec 18, 2024 • edited by metamaskbot Loading

Bitrise

codecov-commenter commented Dec 18, 2024 • edited Loading

Codecov Report

github-actions bot commented Jan 23, 2025 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Jan 23, 2025 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Jan 23, 2025 • edited by metamaskbot Loading

Bitrise

sonarqubecloud bot commented Jan 23, 2025

Quality Gate passed

EtherWizard33 left a comment

Choose a reason for hiding this comment

christopherferreira9 left a comment

Choose a reason for hiding this comment

tommasini commented Dec 17, 2024 •

edited

Loading

github-actions bot commented Dec 17, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Dec 18, 2024 •

edited by metamaskbot

Loading

codecov-commenter commented Dec 18, 2024 •

edited

Loading

github-actions bot commented Jan 23, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Jan 23, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Jan 23, 2025 •

edited by metamaskbot

Loading