fix: ensure marketing consent is explicitly tracked as boolean #12926

jonybur · 2025-01-10T13:04:09Z

Description

Currently, when users decline marketing consent during onboarding, the has_marketing_consent property is not being set at all in the analytics. This creates inconsistent data where we can't properly track users who explicitly opted out of marketing.

This PR modifies the OptinMetrics component to explicitly set has_marketing_consent to either true or false based on the user's choice, ensuring we have complete analytics data for all user decisions regarding marketing consent.

Related issues

Fixes: https://github.com/MetaMask/mobile-planning/issues/2086

Manual testing steps

Fresh install the app
Go through onboarding until you reach the "Help us improve MetaMask" screen
Test both scenarios:
- Accept metrics but decline marketing consent checkbox
- Accept both metrics and marketing consent
Verify in analytics that has_marketing_consent is properly set to false in first case and true in second case

Screenshots/Recordings

Before

Analytics data missing has_marketing_consent property when user declines marketing consent

After

Analytics data showing explicit has_marketing_consent: false when user declines marketing consent

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-01-10T13:04:21Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions · 2025-01-10T13:06:22Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 87e744c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a011f1e6-bdcd-4020-acba-ec6c58ae6666

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

NicolasMassart · 2025-01-10T14:11:41Z

app/components/UI/OptinMetrics/index.js

+    metrics.trackEvent(
+      metrics
+        .createEventBuilder(MetaMetricsEvents.ANALYTICS_PREFERENCE_SELECTED)
+        .addProperties({
+          ...dataCollectionForMarketingTraits,
+          is_metrics_opted_in: true,
+          location: 'onboarding_metametrics',
+          updated_after_onboarding: false,
+        })
+        .build(),
+    );

-      // trait indicating if user opts in for data collection for marketing
-      let dataCollectionForMarketingTraits;
-      if (this.props.isDataCollectionForMarketingEnabled) {
-        dataCollectionForMarketingTraits = { has_marketing_consent: true };
-      }
+    await metrics.enable();


this can not work if you track the event before await metrics.enable();.
The tracking will be skipped.

github-actions · 2025-01-10T15:43:53Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 82199aa
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3d9b1e0d-eb2a-4f14-93f1-35f8647be175

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

…metamask-mobile into marketing-consent-tracking-bug

github-actions · 2025-01-10T16:05:53Z

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 38f1ecc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ffc8ed1e-d90c-4005-8ef6-406fc7cfa2c2

Note

This comment will auto-update when build completes
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2025-01-10T16:17:41Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6954b0c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/abc612f1-eb2e-4799-bf04-bcf2a22ec513

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

sonarqubecloud · 2025-01-10T16:23:57Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ensure marketing consent is explicitly tracked as boolean

87e744c

metamaskbot added the team-wallet-ux label Jan 10, 2025

jonybur added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 10, 2025

jonybur added 2 commits January 10, 2025 13:43

Move trackEvent, metrics enable outside of runAfterInteractions

5dfb85b

Readd comment

1903731

NicolasMassart reviewed Jan 10, 2025

View reviewed changes

Move metrics enable

82199aa

jonybur added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 10, 2025

jonybur added 3 commits January 10, 2025 15:47

Merge branch 'main' into marketing-consent-tracking-bug

4cd8bd8

Fix test

0040151

Merge branch 'marketing-consent-tracking-bug' of github.com:MetaMask/…

38f1ecc

…metamask-mobile into marketing-consent-tracking-bug

jonybur marked this pull request as ready for review January 10, 2025 16:05

jonybur requested a review from a team as a code owner January 10, 2025 16:05

jonybur added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 10, 2025

jonybur requested a review from NicolasMassart January 10, 2025 16:08

update test

6954b0c

jonybur added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: ensure marketing consent is explicitly tracked as boolean #12926

fix: ensure marketing consent is explicitly tracked as boolean #12926

jonybur commented Jan 10, 2025 •

edited

Loading

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025 •

edited by metamaskbot

Loading

NicolasMassart Jan 10, 2025

github-actions bot commented Jan 10, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025 •

edited by metamaskbot

Loading

sonarqubecloud bot commented Jan 10, 2025

fix: ensure marketing consent is explicitly tracked as boolean #12926

Are you sure you want to change the base?

fix: ensure marketing consent is explicitly tracked as boolean #12926

Conversation

jonybur commented Jan 10, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025 • edited by metamaskbot Loading

Bitrise

NicolasMassart Jan 10, 2025

Choose a reason for hiding this comment

github-actions bot commented Jan 10, 2025 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Jan 10, 2025

Bitrise

github-actions bot commented Jan 10, 2025 • edited by metamaskbot Loading

Bitrise

sonarqubecloud bot commented Jan 10, 2025

Quality Gate passed

jonybur commented Jan 10, 2025 •

edited

Loading

github-actions bot commented Jan 10, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Jan 10, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Jan 10, 2025 •

edited by metamaskbot

Loading