Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,7 @@
"@metamask/abi-utils": "^3.0.0",
"@metamask/auto-changelog": "^5.3.0",
"@metamask/browser-passworder": "^5.0.0",
"@metamask/browser-playground": "0.2.0",
"@metamask/browser-playground": "file:../connect-monorepo/playground/browser-playground",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local file path dependency for browser-playground package

High Severity

The @metamask/browser-playground dependency was changed from the npm version "0.2.0" to a local file reference "file:../connect-monorepo/playground/browser-playground", pointing to a directory outside the repository. This will cause yarn install to fail for any developer or CI environment that doesn't have this exact local monorepo checkout at the specified relative path.

Additional Locations (1)

Fix in Cursor Fix in Web

Triggered by project rule: BUGBOT Rules

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requires a browser playground release

"@metamask/build-utils": "^3.0.0",
"@metamask/eslint-config-typescript": "^10.0.0",
"@metamask/eslint-plugin-design-tokens": "^1.0.0",
Expand Down
44 changes: 30 additions & 14 deletions tests/performance/mm-connect/connection-evm.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@ import { test } from 'appwright';

import { login } from '../../framework/utils/Flows.js';
import {
launchMobileBrowser,
switchToMobileBrowser,
navigateToDapp,
refreshMobileBrowser,
launchMobileBrowser,
} from '../../framework/utils/MobileBrowser.js';
import WalletMainScreen from '../../../wdio/screen-objects/WalletMainScreen.js';
import BrowserPlaygroundDapp from '../../../wdio/screen-objects/BrowserPlaygroundDapp.js';
Expand Down Expand Up @@ -52,7 +53,7 @@ test.afterAll(async () => {
await playgroundServer.stop();
});

test('@metamask/connect-evm - Connect via EVM Legacy Connection to Local Browser Playground', async ({
test.skip('@metamask/connect-evm - Connect via EVM Legacy Connection to Local Browser Playground', async ({
device,
}) => {
const platform = device.getPlatform?.() || 'android';
Expand All @@ -74,10 +75,25 @@ test('@metamask/connect-evm - Connect via EVM Legacy Connection to Local Browser

await AppwrightHelpers.withNativeAction(device, async () => {
await login(device);
await WalletMainScreen.isMainWalletViewVisible();

// Cycle the app to ensure all account groups are created
await AppwrightGestures.terminateApp(device);
await AppwrightGestures.activateApp(device);
await login(device);
await WalletMainScreen.isMainWalletViewVisible();
await WalletMainScreen.tapIdenticon();
await AccountListComponent.isComponentDisplayed();
await AccountListComponent.waitForSyncingToComplete();
await AppwrightGestures.terminateApp(device);
await AppwrightGestures.activateApp(device);
await login(device);
await WalletMainScreen.isMainWalletViewVisible();

await launchMobileBrowser(device);
await navigateToDapp(device, DAPP_URL, DAPP_NAME);
});
await new Promise((resolve) => setTimeout(resolve, 5000));
await new Promise((resolve) => setTimeout(resolve, 1000));

await AppwrightHelpers.withWebAction(
device,
Expand All @@ -96,7 +112,7 @@ test('@metamask/connect-evm - Connect via EVM Legacy Connection to Local Browser
});

await new Promise((resolve) => setTimeout(resolve, 1000));
await launchMobileBrowser(device);
await switchToMobileBrowser(device);
await new Promise((resolve) => setTimeout(resolve, 1000));

await AppwrightHelpers.withWebAction(
Expand All @@ -116,7 +132,7 @@ test('@metamask/connect-evm - Connect via EVM Legacy Connection to Local Browser
});

await new Promise((resolve) => setTimeout(resolve, 1000));
await launchMobileBrowser(device);
await switchToMobileBrowser(device);
await new Promise((resolve) => setTimeout(resolve, 1000));

await AppwrightHelpers.withWebAction(
Expand All @@ -138,7 +154,7 @@ test('@metamask/connect-evm - Connect via EVM Legacy Connection to Local Browser
});

await new Promise((resolve) => setTimeout(resolve, 1000));
await launchMobileBrowser(device);
await switchToMobileBrowser(device);
await new Promise((resolve) => setTimeout(resolve, 1000));

await AppwrightHelpers.withWebAction(
Expand All @@ -158,7 +174,7 @@ test('@metamask/connect-evm - Connect via EVM Legacy Connection to Local Browser
});

await new Promise((resolve) => setTimeout(resolve, 1000));
await launchMobileBrowser(device);
await switchToMobileBrowser(device);
await new Promise((resolve) => setTimeout(resolve, 1000));

await AppwrightHelpers.withWebAction(
Expand All @@ -177,7 +193,7 @@ test('@metamask/connect-evm - Connect via EVM Legacy Connection to Local Browser
});

await new Promise((resolve) => setTimeout(resolve, 1000));
await launchMobileBrowser(device);
await switchToMobileBrowser(device);
await new Promise((resolve) => setTimeout(resolve, 1000));

await AppwrightHelpers.withWebAction(
Expand Down Expand Up @@ -205,7 +221,7 @@ test('@metamask/connect-evm - Connect via EVM Legacy Connection to Local Browser
});

await new Promise((resolve) => setTimeout(resolve, 1000));
await launchMobileBrowser(device);
await switchToMobileBrowser(device);
await new Promise((resolve) => setTimeout(resolve, 1000));

await AppwrightHelpers.withWebAction(
Expand Down Expand Up @@ -239,7 +255,7 @@ test('@metamask/connect-evm - Connect via EVM Legacy Connection to Local Browser
});

await new Promise((resolve) => setTimeout(resolve, 1000));
await launchMobileBrowser(device);
await switchToMobileBrowser(device);
await new Promise((resolve) => setTimeout(resolve, 1000));

await AppwrightHelpers.withWebAction(
Expand All @@ -266,7 +282,7 @@ test('@metamask/connect-evm - Connect via EVM Legacy Connection to Local Browser
});

await new Promise((resolve) => setTimeout(resolve, 1000));
await launchMobileBrowser(device);
await switchToMobileBrowser(device);
await new Promise((resolve) => setTimeout(resolve, 1000));

await AppwrightHelpers.withWebAction(
Expand All @@ -286,7 +302,7 @@ test('@metamask/connect-evm - Connect via EVM Legacy Connection to Local Browser
});

await new Promise((resolve) => setTimeout(resolve, 1000));
await launchMobileBrowser(device);
await switchToMobileBrowser(device);
await new Promise((resolve) => setTimeout(resolve, 1000));

await AppwrightHelpers.withWebAction(
Expand All @@ -312,7 +328,7 @@ test('@metamask/connect-evm - Connect via EVM Legacy Connection to Local Browser
});

await new Promise((resolve) => setTimeout(resolve, 1000));
await launchMobileBrowser(device);
await switchToMobileBrowser(device);
await new Promise((resolve) => setTimeout(resolve, 1000));

await AppwrightHelpers.withNativeAction(device, async () => {
Expand Down Expand Up @@ -345,7 +361,7 @@ test('@metamask/connect-evm - Connect via EVM Legacy Connection to Local Browser
});

await new Promise((resolve) => setTimeout(resolve, 1000));
await launchMobileBrowser(device);
await switchToMobileBrowser(device);
await new Promise((resolve) => setTimeout(resolve, 1000));

await AppwrightHelpers.withWebAction(
Expand Down
2 changes: 1 addition & 1 deletion tests/performance/mm-connect/connection-multichain.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ test.afterAll(async () => {
await playgroundServer.stop();
});

test('@metamask/connect-multichain - Connect via Multichain API to Local Browser Playground', async ({
test.skip('@metamask/connect-multichain - Connect via Multichain API to Local Browser Playground', async ({
device,
}) => {
// Get platform-specific URL (use bs-local.com when running on BrowserStack Local tunnel)
Expand Down
Loading