Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cherry pick PR improvement #7793

Merged
merged 28 commits into from
Jan 17, 2024
Merged

fix: cherry pick PR improvement #7793

merged 28 commits into from
Jan 17, 2024

Conversation

sethkfman
Copy link
Contributor

@sethkfman sethkfman commented Nov 14, 2023

Description

This PR fixes fetching of all the branches needed to create the cherry pick PRs.

Linked test PR that was created from action:

Related issues

Fixes: NA

Manual testing steps

  1. Go to the action page & select "Create Cherry Pick PR"
  2. Select run workflow from fix/cherry-pick-node-version
  3. Enter base branch, commit hash and PR number
  4. PR should be successfully created unless conflicts occur in the creation and action should fail.

Screenshots/Recordings

Link successful PR runs

Before

https://github.com/MetaMask/metamask-mobile/actions/runs/6867014033

After

Successful cherry-pick: #8316
https://github.com/MetaMask/metamask-mobile/actions/runs/7562792265

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sethkfman sethkfman requested a review from a team as a code owner November 14, 2023 14:42
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman added team-mobile-client release-7.12.0 Issue or pull request that will be included in release 7.12.0 labels Nov 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f791282) 40.21% compared to head (66a80b9) 40.21%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7793   +/-   ##
=======================================
  Coverage   40.21%   40.21%           
=======================================
  Files        1235     1235           
  Lines       29885    29885           
  Branches     2863     2863           
=======================================
  Hits        12018    12018           
  Misses      17176    17176           
  Partials      691      691           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sethkfman sethkfman added team-mobile-client release-7.16.0 Issue or pull request that will be included in release 7.16.0 and removed release-7.12.0 Issue or pull request that will be included in release 7.12.0 labels Jan 17, 2024
Copy link

sonarcloud bot commented Jan 17, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

frankvonhoven
frankvonhoven previously approved these changes Jan 17, 2024
Copy link
Contributor

@frankvonhoven frankvonhoven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, worked in the wild 🚀

@metamaskbot metamaskbot added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 17, 2024
Copy link

sonarcloud bot commented Jan 17, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sethkfman sethkfman merged commit 5413123 into main Jan 17, 2024
29 checks passed
@sethkfman sethkfman deleted the fix/cherry-pick-node-version branch January 17, 2024 23:34
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 17, 2024
@sethkfman sethkfman self-assigned this Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.16.0 Issue or pull request that will be included in release 7.16.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants