fix: fix keyring_createAccount idempotency
#556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccharly
commented
Nov 5, 2025
packages/snap/snap.manifest.json
Outdated
| @@ -1,13 +1,13 @@ | |||
| { | |||
| "version": "1.4.3", | |||
| "version": "1.4.4", | |||
Contributor
Author
There was a problem hiding this comment.
Looks like the release workflow does not automatically update this?
ccharly
commented
Nov 5, 2025
Comment on lines
-168
to
-173
| await this.#snapClient.emitAccountCreatedEvent( | ||
| account, | ||
| correlationId, | ||
| accountName, | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
We still have an emitAccountCreatedEvent below, when the account got inserted for the first time.
ccharly
force-pushed
the
fix/create-account-idempotency
branch
from
92fac71 to
ce50bb0
Compare
ccharly
force-pushed
the
fix/create-account-idempotency
branch
from
ce50bb0 to
d57dc39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
notify:accountCreatedevent was fired even for existing accounts, which would cause errors in theSnapKeyringhandling (if the account has not been created already):Similarly to the Solana Snap, if the account already exists, we just return the
KeyringAccountobject and that's it:Note
Stop emitting accountCreated when the account already exists; bump Snap version to 1.6.0.
AccountUseCases.create: Return existing account without emittingaccountCreatedto ensure idempotency.packages/snap/snap.manifest.jsonversion to1.6.0and updatesource.shasum.Written by Cursor Bugbot for commit d57dc39. This will update automatically on new commits. Configure here.