Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add size prop to Text #2908

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Add size prop to Text #2908

merged 2 commits into from
Nov 26, 2024

Conversation

GuillaumeRx
Copy link
Contributor

@GuillaumeRx GuillaumeRx commented Nov 26, 2024

This adds a new optional prop to Text called size.

It allows two values, sm and md that relates to bodySm and bodyMd in extension.

It should default to md.

Fixes: #2905

@GuillaumeRx GuillaumeRx requested a review from a team as a code owner November 26, 2024 10:23
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.48%. Comparing base (a5714d5) to head (44929c6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2908   +/-   ##
=======================================
  Coverage   94.48%   94.48%           
=======================================
  Files         487      487           
  Lines       10427    10427           
  Branches     1598     1598           
=======================================
  Hits         9852     9852           
  Misses        575      575           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
@GuillaumeRx GuillaumeRx merged commit cbe55de into main Nov 26, 2024
166 checks passed
@GuillaumeRx GuillaumeRx deleted the gr/add-test-sizes branch November 26, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose more Text size variants on the Text component
3 participants