Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Webpack plugin example Snap for testing updates #3186

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Mar 3, 2025

Bumping the BIP-32 example in #3185 caused issues in the MetaMask extension E2E tests. We don't update the Webpack plugin example so often, and it's not on the test-snaps page directly, so less likely to cause issues in the future.

@Mrtenz Mrtenz requested a review from a team as a code owner March 3, 2025 14:59
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.93%. Comparing base (2aadca0) to head (a5b0c6e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3186   +/-   ##
=======================================
  Coverage   94.93%   94.93%           
=======================================
  Files         507      507           
  Lines       11184    11184           
  Branches     1722     1722           
=======================================
  Hits        10618    10618           
  Misses        566      566           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mrtenz Mrtenz added this pull request to the merge queue Mar 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 3, 2025
@Mrtenz Mrtenz added this pull request to the merge queue Mar 3, 2025
Merged via the queue into main with commit 73956c4 Mar 3, 2025
123 checks passed
@Mrtenz Mrtenz deleted the mrtenz/use-webpack-plugin-example branch March 3, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants