Make Nextcloud version comparison with int instead of string. (#45)

* Make Nextcloud version comparison with int instead of string.

.gitignore

@@ -9,3 +9,4 @@ geckodriver.log
 /config.json
 /config.toml
 /dist
+/.mypy_cache

.vscode/settings.json

@@ -5,15 +5,14 @@
   "python.linting.mypyEnabled": false,
   "python.linting.mypyPath": ".venv/bin/mypy",
   "python.testing.pytestPath": ".venv/bin/pytest",
+  "python.linting.pylintEnabled": false,
   "python.linting.pylintPath": ".venv/bin/pylint",
   "python.linting.banditPath": ".venv/bin/bandit",
   "python.formatting.provider": "black",
   "python.analysis.typeCheckingMode": "off",
-  "python.analysis.extraPaths": [
-    "./talked"
-  ],
+  "python.analysis.extraPaths": ["./talked"],
   "[python]": {
-    "editor.codeActionsOnSave": {"source.organizeImports": true},
+    "editor.codeActionsOnSave": { "source.organizeImports": true }
   },
-  "autoDocstring.startOnNewLine": true,
+  "autoDocstring.startOnNewLine": true
 }

CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## [Unreleased]
 
+## 0.3.2 - 2022-03-23
+
+### Fixed
+
+-   Make Nextcloud version comparison with int instead of string.
+
 ## 0.3.1 - 2022-01-11
 
 ### Fixed

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "talked"
-version = "0.3.1"
+version = "0.3.2"
 description = "Call recording for Nextcloud Talk"
 authors = ["Magnus Walbeck <mw@mwalbeck.org>"]
 license = "AGPL-3.0-or-later"

talked/__init__.py

@@ -5,7 +5,7 @@
 
 from tomlkit import parse
 
-__version__ = "0.3.1"
+__version__ = "0.3.2"
 
 LOG_LEVELS = {
     "critical": logging.CRITICAL,

talked/recorder.py

@@ -28,7 +28,7 @@ def start(
     token: str,
     queue: Queue,
     recording: Event,
-    nextcloud_version: str,
+    nextcloud_version: int,
     audio_only: bool,
     grid_view: bool,
 ) -> None:
@@ -109,7 +109,7 @@ def start(
 
 
 def launch_browser(
-    call_link: str, msg_queue: Queue, nextcloud_version: str, grid_view: bool
+    call_link: str, msg_queue: Queue, nextcloud_version: int, grid_view: bool
 ) -> WebDriver:
     logging.info("Configuring browser options")
     options = Options()
@@ -201,7 +201,7 @@ def change_name_of_user(driver: WebDriver) -> None:
     )
 
 
-def join_call(driver: WebDriver, msg_queue: Queue, nextcloud_version: str) -> None:
+def join_call(driver: WebDriver, msg_queue: Queue, nextcloud_version: int) -> None:
     # Wait for the green Join Call button to appear then click it
     logging.info("Waiting for join call button to appear")
     try:
@@ -223,7 +223,7 @@ def join_call(driver: WebDriver, msg_queue: Queue, nextcloud_version: str) -> No
     logging.info("Joining call")
     join_call_button.click()
 
-    if nextcloud_version == "23":
+    if nextcloud_version == 23:
         logging.info("Handling device checker screen")
         try:
             device_checker_join_call_button = WebDriverWait(driver, 10).until(
@@ -267,11 +267,11 @@ def mute_user(driver: WebDriver) -> None:
         logging.info(("Mute button wasn't found. Assuming we are already muted."))
 
 
-def switch_to_speaker_view(driver: WebDriver, nextcloud_version: str) -> None:
+def switch_to_speaker_view(driver: WebDriver, nextcloud_version: int) -> None:
     # Switch to speaker view
     logging.info("Switching to speaker view")
 
-    if nextcloud_version == "23":
+    if nextcloud_version == 23:
         driver.find_element_by_css_selector(
             ".local-media-controls button.action-item__menutoggle"
         ).click()