Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for repositories with multiple GEMs (f. ex. strain collections) #37

Open
4 tasks done
famosab opened this issue Nov 2, 2022 · 1 comment
Open
4 tasks done
Labels
enhancement New feature or request

Comments

@famosab
Copy link
Collaborator

famosab commented Nov 2, 2022

Description of the issue:

So far only singular GEM repositories fit within the standard-GEM template. While some parts can easily be used with multiple GEMs, such as the overall structure, other things fall short when multiple GEMs are hosted in one repository.

Expected feature/value/output:

There are two ways how to approach this:

  1. One could either extend this repository to be applicable to repositories with multiple GEMs
  2. Or create a separate template for multiple-GEM-repositories

A few changes that directly came to my mind are:

  • the model folder would need to change to models
  • one model format should be stored in the models folder (f. ex. xml) conversions into other formats could be done via github actions and stored either in subfolders (within the models folder) or different folders in the repository (f.ex. a folder called json for all json models etc.)
  • the naming convention for the GEMs needs to be adapted
  • as a possible Memote report, a memote report diff would be preferable over reports for every model

Current feature/value/output:

Not available.

I hereby confirm that I have:

  • Tested my code with all requirements for running the model
  • Done this analysis in the main branch of the repository
  • Checked that a similar issue does not exist already
  • If needed, asked first in the Gitter chat room about the issue
@famosab famosab added the enhancement New feature or request label Nov 2, 2022
@draeger
Copy link
Collaborator

draeger commented Nov 3, 2022

Just a very minor note: I'd keep the model directory without the plural form. Rationale: When talking about the source code of a program, we also typically refer to multiple source files. Still, it is not called source codes. The singular is appropriate here as an unmarked form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants