Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sc-29929] invalid multi oas config #1046

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

elic-eon
Copy link
Contributor

@elic-eon elic-eon commented Nov 20, 2024

🤔 Why?

specs:
  - base_url: <url>
    openapi_json_url: <url>
  - base_url: <url>
    openapi_json_url: <url>

output:
  file:
    directory: <path>

didn't not pass the config validation

🤓 What?

Fix OpenAPIRunConfig validation function

🧪 Tested?

Verified locally

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
13448 12038 90% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/openapi/config.py 95% 🟢
TOTAL 95% 🟢

updated for commit: a5d2aa7 by action🐍

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.51%. Comparing base (81572b4) to head (a5d2aa7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1046   +/-   ##
=======================================
  Coverage   89.51%   89.51%           
=======================================
  Files         211      211           
  Lines       13448    13448           
=======================================
  Hits        12038    12038           
  Misses       1410     1410           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@elic-eon elic-eon enabled auto-merge (squash) November 20, 2024 09:59
@elic-eon elic-eon merged commit a42a0d6 into main Nov 20, 2024
6 checks passed
@elic-eon elic-eon deleted the scotthuang/sc-29929/invalid-multi-oas-config branch November 20, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants