Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickSight crawler unsupported dataset type [sc-30088] #1059

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

alyiwang
Copy link
Contributor

@alyiwang alyiwang commented Jan 9, 2025

🤔 Why?

The quickSight DescribeDataSet API may throw error for some dataset type such as file formats (csv, s3 file, etc)

🤓 What?

  • add try catch to not fail the entire crawler when DescribeDataSet error is thrown
  • dump the list API response for debugging

🧪 Tested?

tested against Metaphor instance, but need to test on customer env to log the issue

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

@alyiwang alyiwang requested a review from mars-lan January 9, 2025 19:59
@alyiwang alyiwang enabled auto-merge (squash) January 9, 2025 19:59
Copy link
Contributor

@mars-lan mars-lan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix.

Copy link

github-actions bot commented Jan 9, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
13542 12131 90% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/quick_sight/client.py 84% 🟢
TOTAL 84% 🟢

updated for commit: e032c85 by action🐍

@alyiwang alyiwang merged commit 8e1d030 into main Jan 9, 2025
4 checks passed
@alyiwang alyiwang deleted the yi.wang/sc-30088/quicksight-crawler-crashing branch January 9, 2025 20:06
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@a580861). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
metaphor/quick_sight/client.py 57.14% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1059   +/-   ##
=======================================
  Coverage        ?   89.58%           
=======================================
  Files           ?      210           
  Lines           ?    13542           
  Branches        ?        0           
=======================================
  Hits            ?    12131           
  Misses          ?     1411           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants