Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timeout to SQL parsing #1063

Merged
merged 1 commit into from
Jan 14, 2025
Merged

add timeout to SQL parsing #1063

merged 1 commit into from
Jan 14, 2025

Conversation

alyiwang
Copy link
Contributor

🤔 Why?

The SQL parser may stuck for some particular SQL queries.

🤓 What?

  • Add timeout to SQL parsing

🧪 Tested?

tested on Metaphor instance, add sleep to trigger timeout

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

@alyiwang alyiwang requested a review from mars-lan January 14, 2025 01:11
@alyiwang alyiwang enabled auto-merge (squash) January 14, 2025 01:12
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
13557 12134 90% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/common/sql/table_level_lineage/table_level_lineage.py 78% 🟢
metaphor/quick_sight/lineage.py 89% 🟢
TOTAL 83% 🟢

updated for commit: 6b83952 by action🐍

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 89.50%. Comparing base (8ebe493) to head (6b83952).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...mon/sql/table_level_lineage/table_level_lineage.py 45.45% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1063      +/-   ##
==========================================
- Coverage   89.53%   89.50%   -0.03%     
==========================================
  Files         210      210              
  Lines       13547    13557      +10     
==========================================
+ Hits        12129    12134       +5     
- Misses       1418     1423       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alyiwang alyiwang merged commit e2d4deb into main Jan 14, 2025
4 of 6 checks passed
@alyiwang alyiwang deleted the quicksight branch January 14, 2025 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants