Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update quicksight parsing timeout #1065

Merged
merged 2 commits into from
Jan 15, 2025
Merged

update quicksight parsing timeout #1065

merged 2 commits into from
Jan 15, 2025

Conversation

alyiwang
Copy link
Contributor

🤔 Why?

Quicksight crawler may stuck at the parsing phase.

🤓 What?

  • Use func-timeout lib instead of the signal
  • Add timeout at the dataset parsing level
  • add a bit more progress tracker

🧪 Tested?

tested on Metaphor instance, also manually triggered timer

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

@alyiwang alyiwang requested a review from mars-lan January 14, 2025 23:55
@alyiwang alyiwang enabled auto-merge (squash) January 14, 2025 23:55
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
13562 12138 90% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/common/sql/table_level_lineage/table_level_lineage.py 78% 🟢
metaphor/quick_sight/client.py 83% 🟢
metaphor/quick_sight/extractor.py 92% 🟢
TOTAL 84% 🟢

updated for commit: 3cd7d6c by action🐍

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 89.50%. Comparing base (1397d4e) to head (3cd7d6c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
metaphor/quick_sight/extractor.py 84.61% 4 Missing ⚠️
metaphor/quick_sight/client.py 66.66% 2 Missing ⚠️
...mon/sql/table_level_lineage/table_level_lineage.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1065      +/-   ##
==========================================
- Coverage   89.50%   89.50%   -0.01%     
==========================================
  Files         210      210              
  Lines       13557    13562       +5     
==========================================
+ Hits        12134    12138       +4     
- Misses       1423     1424       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alyiwang alyiwang merged commit 1297523 into main Jan 15, 2025
4 of 6 checks passed
@alyiwang alyiwang deleted the quicksight branch January 15, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants