Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update quicksight lineage #1067

Merged
merged 3 commits into from
Jan 17, 2025
Merged

update quicksight lineage #1067

merged 3 commits into from
Jan 17, 2025

Conversation

alyiwang
Copy link
Contributor

@alyiwang alyiwang commented Jan 16, 2025

🤔 Why?

The upstream snowflake URL sometimes contains the default region us-west-2 that needs to be stripped to match the account name from Snowflake crawler.

Also in some cases, when the lineage parser needs to find an existing dataset, it used quicksight dataset_id but the dictionary used arn as key, should all use id instead.

🤓 What?

  • update snowflake account to remove default region
  • update MCE dictionary to use id as key instead of arn
  • refactor lineage parsing
  • in the Virtual View and Dashboard logical ID, use the Quicksight ID instead of ARN as name.

🧪 Tested?

tested on Metaphor instance

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

@alyiwang alyiwang requested a review from mars-lan January 16, 2025 23:53
@alyiwang alyiwang enabled auto-merge (squash) January 16, 2025 23:55
Copy link

github-actions bot commented Jan 17, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
13589 12162 90% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/common/snowflake.py 100% 🟢
metaphor/quick_sight/data_source_utils.py 98% 🟢
metaphor/quick_sight/extractor.py 91% 🟢
metaphor/quick_sight/lineage.py 89% 🟢
TOTAL 94% 🟢

updated for commit: a91231c by action🐍

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 86.23853% with 15 lines in your changes missing coverage. Please review.

Project coverage is 89.49%. Comparing base (62bb023) to head (a91231c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
metaphor/quick_sight/lineage.py 83.95% 13 Missing ⚠️
metaphor/quick_sight/extractor.py 90.47% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1067   +/-   ##
=======================================
  Coverage   89.49%   89.49%           
=======================================
  Files         210      210           
  Lines       13562    13589   +27     
=======================================
+ Hits        12137    12162   +25     
- Misses       1425     1427    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alyiwang alyiwang merged commit 6f6c3a7 into main Jan 17, 2025
5 of 6 checks passed
@alyiwang alyiwang deleted the quicksight branch January 17, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants