Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quicksight crawler add filter [sc-30103] #1068

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

alyiwang
Copy link
Contributor

🤔 Why?

This is to avoid fetching all the metadata from quicksight and causing noise.

🤓 What?

  • add a filter based on dashboard IDs to selectively include dashboards and data sets in the final results

🧪 Tested?

tested on metaphor instance

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

@alyiwang alyiwang requested a review from mars-lan January 22, 2025 00:10
@alyiwang alyiwang enabled auto-merge (squash) January 22, 2025 00:10
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
13627 12198 90% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/quick_sight/config.py 100% 🟢
metaphor/quick_sight/extractor.py 91% 🟢
metaphor/quick_sight/lineage.py 89% 🟢
TOTAL 93% 🟢

updated for commit: 1e847fb by action🐍

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 95.45455% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.51%. Comparing base (6f6c3a7) to head (1e847fb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
metaphor/quick_sight/extractor.py 94.28% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1068      +/-   ##
==========================================
+ Coverage   89.49%   89.51%   +0.01%     
==========================================
  Files         210      210              
  Lines       13589    13627      +38     
==========================================
+ Hits        12162    12198      +36     
- Misses       1427     1429       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alyiwang alyiwang merged commit 14eef78 into main Jan 22, 2025
6 checks passed
@alyiwang alyiwang deleted the yi.wang/sc-30103/quicksight-crawler-add-filter branch January 22, 2025 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants