-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OwnershipAssignment
to dbt VirtualView
#653
Add OwnershipAssignment
to dbt VirtualView
#653
Conversation
Signed-off-by: Tsung-Ju Lii <andy@metaphor.io>
This pull request has been linked to Shortcut Story #20587: Add meta ownership to dbt models. |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 31 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also add a config to control the desired behavior, i.e., assigning owners to dbt model, materialized tables, or both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's address #653 (comment) before merging.
This reverts commit f7ca70f.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
🤔 Why?
Enables assigning ownership to dbt model's virtual views, or both the virtual view and the dataset itself.
Tracked by SC20587
🤓 What?
🧪 Tested?
Tested with the newly added config, the ownership information was added correctly.