Upgrade to Python 3.10 #737
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #23264: S3 crawler. |
|
Actually this is probably not necessary... closing this |
Yeah prefer to keep python 3.8 for another 6 months till near EOL for maximum compatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Why?
snowflake-connector-pythonhas aurllib3dependency that's stuck in v1.x, while some other libraries (e.g. tableuserverclient, minio for s3 crawler) depends on urllib3 v2.x.In snowflakedb/snowflake-connector-python#1743 they got rid of the urllib3 dependency altogether for python >= 3.10, so it makes sense to upgrade our minimum supported python version from 3.8 to 3.10 in order to be able to upgrade other libraries.
🤓 What?
🧪 Tested?
☑️ Checks
pyproject.toml.