Refactor mc ica #12
Open
Refactor mc ica #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added cmake-based build system
lxavier
commented
Mar 8, 2021
|
|
||
| !$acc loop independent worker |
There was a problem hiding this comment.
@FrostyMike is there a reason why you use worker and not vector for the inner most loop ?
There was a problem hiding this comment.
Yes, check the old message in slack channel for details.
"2. Compiler (pgfortran 20.11) does not respect OpenACC "vector_length" specification.
This means that Gang -> Vector parallelism model I outlined in my variants is not going to work as is. However, this can be easily fixed by introducing workers, in the amount required to fill the vector. I.e. if you want 1 vector of 128 threads, create 4 workers with 32 threads each instead."
huppd
pushed a commit
that referenced
this pull request
Oct 11, 2021
Merge in ESCAPE/dwarf-p-radiation-ecrad from dwd-verbose-aerosol to master * commit 'b37dcdef664cc6d11188cbc1a647217196f612be': [dwd-verbose-aerosol] Moved aerosol_optics%print_description call into iverbosesetup >= 1 as this produces a lot of stdout otherwise (when running with multiple tasks)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to discuss this implementation - not necessarily for merging
Note compilation on daint