Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

Reduced test data #100

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Reduced test data #100

merged 3 commits into from
Dec 18, 2023

Conversation

cfkanesan
Copy link
Collaborator

Purpose

Run tests on a reduced test dataset by default to speed up the test suite.

Code changes:

  • Added the custom pytest marker data
  • Remove the system_defintion module

Superseeds #88

@cfkanesan cfkanesan requested a review from cosunae December 11, 2023 13:46
if marker is None:
return base_dir / "datasets/32_39x45_51"
match marker.args[0]:
case "original":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use an enum insted of plain strings?

Copy link
Contributor

@cosunae cosunae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe have you considered the comment from Stefan?
Otherwise looks good to me

@cfkanesan
Copy link
Collaborator Author

maybe have you considered the comment from Stefan? Otherwise looks good to me

Yes but I'm not sure where to place the enum in order to make it useful for someone who is writing a test. There is a concept of a global namespace in pytest but I don't think that's picked up by vscode.

@cfkanesan cfkanesan merged commit 9a886fa into main Dec 18, 2023
1 check passed
@cfkanesan cfkanesan deleted the reduced-test-data branch December 18, 2023 08:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants