Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

Refactor constants #111

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Refactor constants #111

merged 3 commits into from
Jan 5, 2024

Conversation

cfkanesan
Copy link
Collaborator

Purpose

Improve the consistency of the physical constants

Code changes

  • The constants module is renamed to physical constants and the pc_ prefix is dropped in favour of aliasing the module to pc at the call sites

@victoria-cherkas victoria-cherkas self-requested a review January 4, 2024 11:03
Comment on lines 30 to 31
surface_pressure_ref = 101325.0

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come this is not in the physical_constants file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems more like reference value rather than a physical constant but I can move it there if you prefer.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its better in the constant file, it coud be useful somewhere else too.

@cfkanesan cfkanesan merged commit 6bfa894 into main Jan 5, 2024
1 of 2 checks passed
@cfkanesan cfkanesan deleted the refactor-constants branch January 5, 2024 13:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants