Skip to content

Conversation

@chri-k
Copy link
Contributor

@chri-k chri-k commented Nov 23, 2025

Type of change

  • Bug fix
  • New feature

Description

adds an enemies list and moderately refactors target selection.

TargetUtils and Friends are deprecated and replaced with systems.targeting.Targeting.
(it might be better to delete them entirely, since the substitution subtly modifies behaviour)

future modifications to target selection (per-entity-type priorities would be useful) should not disrupt existing code as much as a result.

this is opened with the purpose of collecting feedback on both the implementation and the UX.

a bit of UI is missing. config migration code (for every single module setting which got expanded) is missing and not planned unless crosby's setting migration thing happens.

warning: this was produced near midnight.

Related issues

#5874
#3629
#3767

How Has This Been Tested?

currently completely untested. since a very large amount of modules was affected and this is only testable in a multiplayer context, testing is not trivial.

Checklist:

(draft)

@noramibu
Copy link
Contributor

noramibu commented Nov 24, 2025

Isn't it better to implement a relation system instead of having separate enemies and friends system? So people can organize their own relation groups and configure modules for each relation group?

It can be useful for groups where people have multiple groups or would like to share groups list with each other.

@chri-k
Copy link
Contributor Author

chri-k commented Nov 24, 2025

that would be a highly complicated system which only differs in effect on ESP and Tracers (and BetterTab ig)

(that is also bad wording, because the word "system" has special meaning in this codebase, and there is only one of those here)

@chri-k
Copy link
Contributor Author

chri-k commented Nov 24, 2025

and the colour space of the various ESP modules is already cluttered enough for it to be hard to differentiate things, so this is questionably useful

@chri-k
Copy link
Contributor Author

chri-k commented Nov 24, 2025

however there should be an option to save this to profiles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants