Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
adds an enemies list and moderately refactors target selection.
TargetUtilsandFriendsare deprecated and replaced withsystems.targeting.Targeting.(it might be better to delete them entirely, since the substitution subtly modifies behaviour)
future modifications to target selection (per-entity-type priorities would be useful) should not disrupt existing code as much as a result.
this is opened with the purpose of collecting feedback on both the implementation and the UX.
a bit of UI is missing. config migration code (for every single module setting which got expanded) is missing and not planned unless crosby's setting migration thing happens.
warning: this was produced near midnight.
Related issues
#5874
#3629
#3767
How Has This Been Tested?
currently completely untested. since a very large amount of modules was affected and this is only testable in a multiplayer context, testing is not trivial.
Checklist:
(draft)