-
Notifications
You must be signed in to change notification settings - Fork 80
Compounding liquidity #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release_0.2.0
Are you sure you want to change the base?
Conversation
6f27530 to
0c4fe8c
Compare
675bc71 to
eacd7a9
Compare
| if collect_fee_mode == CollectFeeMode::Compounding { | ||
| CompoundingLiquidity::get_initial_pool_information(sqrt_price, liquidity) | ||
| } else { | ||
| ConcenstratedLiquidity::get_initial_pool_information( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo. Should be Concenstrated -> Concentrated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
CHANGELOG.md
Outdated
| ### Added | ||
|
|
||
| - Pool now will track reserves balances `(token_a_amount, token_b_amount)` if `pool.layout_version == 1`. For pool layout_version 0, operator can call the new endpoint `fix_pool_layout_version` to pump pool version. | ||
| - Add a new `collect_fee_mode (Compounding)`, in the new collect fee mode, fee will be collected in quote token, and a percentage of fee (configurable) will be added in reserves for compounding. In the new collect fee mode, the pool doesn't have concenstrated price range, instead following constant-product formula `token_a_amount * token_b_amount = constant`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo. Should be concenstrated -> concentrated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
| [toolchain] | ||
| anchor_version = "0.31.0" | ||
| solana_version = "2.1.0" | ||
| solana_version = "2.3.13" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should update the CI to use the same version in .github/workflows/ci.yml:10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
| ) -> Result<InitialPoolInformation> { | ||
| require!( | ||
| liquidity >= DEAD_LIQUIDITY, | ||
| liquidity > DEAD_LIQUIDITY, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason of the change? Doesn't only DEAD_LIQUIDITY during pool initialization make sense too?
No description provided.