feat: Add video playback support for video songs#2861
Draft
kairosci wants to merge 20 commits intoMetrolistGroup:mainfrom
Draft
feat: Add video playback support for video songs#2861kairosci wants to merge 20 commits intoMetrolistGroup:mainfrom
kairosci wants to merge 20 commits intoMetrolistGroup:mainfrom
Conversation
kairosci
force-pushed
the
feature/video-playback
branch
2 times, most recently
from
66e0703 to
e321811
Compare
Member
|
Feedback: It gives us all a black screen |
Member
|
The settings option could be improved so that we use it within the player as a toggle button at the top instead of Now Playing! |
kairosci
force-pushed
the
feature/video-playback
branch
from
f203d2e to
7e33307
Compare
Member
|
No video player shown yet! |
-Add VideoPlayer component using Media3 PlayerView - Add toggle button in Now Playing header - Add EnableVideoPlaybackKey preference (defaults to true) - Add appearance settings option for video playback - Implement video streaming support in YTPlayerUtils (muxed formats) - Pass video preference from MusicService to streaming layer - Add videocam/videocam_off icons for toggle button
kairosci
force-pushed
the
feature/video-playback
branch
from
7e33307 to
ee2b71b
Compare
Contributor
Author
|
I just discovered that the app only fetched audio, so I need to fetch mixed data. When it's ready, I'll mark it as ready. |
Contributor
If you want adaptive streaming, above 720p you can use built in MergingMediaSource, TVHTML5 is a good primary client too. Might need to apply PoToken and n transform same that we are using for web remix. I think so. Could be wrong. |
…ture/video-playback
- Enhanced muxed format selection algorithm with network-aware quality scoring - Added comprehensive logging for format selection debugging - Improved aspect ratio handling with RESIZE_MODE_FIT for proper centering - Optimized quality preference: 720p on unmetered, 480p on metered connections - Disabled buffering indicator in video player for cleaner UI - Ensured proper full-width video display matching YouTube Music behavior
CRITICAL FIX: Resolves issues where video wouldn't display and audio would block The problem was that enableVideoPlayback was only read at service startup. When users toggled video/audio during playback, the setting wasn't applied. This caused: - Service continued fetching audio-only even after enabling video - VideoPlayer tried to show video but stream had no video tracks - Audio could block due to mismatch between UI and stream format Solution: - Added dataStore listener for EnableVideoPlaybackKey changes - On toggle, service now: 1. Updates enableVideoPlayback value 2. Clears cache for current media 3. Reloads stream with correct format (muxed or audio-only) 4. Resumes playback at same position - Metadata automatically updated via recoverSong with correct isVideoFormat flag Now video playback works seamlessly when toggling between audio/video modes.
|
|
…r for video playback
- Always fetch muxed streams in YTPlayerUtils. - Support switching between audio and video via track selection in MusicService (no reloading). - Force 1:1 aspect ratio for song thumbnails in lists and grids. - Add animated transitions between artwork and video in player. - Ensure official music videos replace Art Tracks when video is enabled.
…pport - Add squareThumbnail support to InnerTube models (Song, Album, Search, Next). - Update player menus and settings for a more consistent muxed experience. - Ensure all relevant UI components use the correct artwork sources.
kairosci
force-pushed
the
feature/video-playback
branch
from
a0e4c02 to
1111bc2
Compare
Contributor
Author
|
ONLY A LITTLE REMINDER. TODO AT 25.2:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Video songs display only static thumbnails instead of playing video content.
Cause
The player lacks video playback integration. While the codebase tracks
isVideoSongmetadata, the UI only renders static images in the thumbnail area for all media types.Solution
Testing
Feature builds successfully. Requires device testing with video songs from YouTube Music to verify playback functionality, performance, and battery impact.
Closes no specific issue (new feature implementation)