feat(playback): add option to cache songs after playback starts#3034
Draft
kairosci wants to merge 2 commits intoMetrolistGroup:mainfrom
Draft
feat(playback): add option to cache songs after playback starts#3034kairosci wants to merge 2 commits intoMetrolistGroup:mainfrom
kairosci wants to merge 2 commits intoMetrolistGroup:mainfrom
Conversation
kairosci
force-pushed
the
feature/cache-after-playback
branch
from
b845624 to
e3fffb4
Compare
kairosci
force-pushed
the
feature/cache-after-playback
branch
3 times, most recently
from
255eb19 to
c06490f
Compare
kairosci
changed the title
kairosci
force-pushed
the
feature/cache-after-playback
branch
5 times, most recently
from
6968698 to
52147a2
Compare
kairosci
force-pushed
the
feature/cache-after-playback
branch
from
52147a2 to
2156f71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Users may want to control when songs are cached during playback. Accidentally started songs can fill up the cache.
Solution
CacheAfterSecondsKeypreference inPreferenceKeys.ktMusicService.ktwithcacheEnabledMediaIdssetStorageSettings.ktwith slider for selecting delay (0%, 25%, 50%, 75%, 90%)metrolist_strings.xmlSongs are now cached at the selected percentage of playback (default 75%).
Testing
Built and tested the cache option in Storage Settings
Closes #3033