fix(ui): make CSV import dialog scrollable#3035
Open
kairosci wants to merge 1 commit intoMetrolistGroup:mainfrom
Open
fix(ui): make CSV import dialog scrollable#3035kairosci wants to merge 1 commit intoMetrolistGroup:mainfrom
kairosci wants to merge 1 commit intoMetrolistGroup:mainfrom
Conversation
- Add vertical scroll to the column in CsvColumnMappingDialog - This fixes buttons being inaccessible when there are many columns - Fixes MetrolistGroup#2999
kairosci
force-pushed
the
kairosci/feature/cache-after-playback
branch
from
fc2be85 to
033866b
Compare
kairosci
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When importing a CSV file with many columns (e.g., from Exportify), the column mapping dialog becomes too tall and the import buttons are not accessible as they are off-screen.
Cause
The CsvColumnMappingDialog did not have vertical scrolling, so with many columns the buttons were hidden below the visible area.
Solution
.verticalScroll(rememberScrollState())) to the main Column inCsvColumnMappingDialog.ktTesting
Built the app and verified the dialog scrolls vertically when there are many columns.
Fixes #2999