fix: remove parentheses and brackets from song title during lyrics search#3042
Open
kairosci wants to merge 1 commit intoMetrolistGroup:mainfrom
Open
fix: remove parentheses and brackets from song title during lyrics search#3042kairosci wants to merge 1 commit intoMetrolistGroup:mainfrom
kairosci wants to merge 1 commit intoMetrolistGroup:mainfrom
Conversation
kairosci
force-pushed
the
fix/remove-parentheses-from-lyrics-search
branch
from
881a236 to
5aa7665
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Lyrics search often returns incorrect or irrelevant results (e.g., Chinese or Japanese lyrics for Western songs) when the song title contains metadata.
Cause
Song titles often contain metadata in parentheses or brackets like
(feat. ...),(Remastered),[Original Mix], etc. These extra strings interfere with the search queries of various lyrics providers, leading to poor match quality or mismatching.Solution
Implemented a
cleanTitleForSearchfunction inLyricsUtilsthat strips all content within parentheses()and square brackets[]from the song title.LyricsHelpernow uses this cleaned title when querying lyrics providers.Testing
Closes #3041