Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh parameters #13

Merged
merged 13 commits into from
Aug 21, 2023
Merged

Refresh parameters #13

merged 13 commits into from
Aug 21, 2023

Conversation

eroten
Copy link
Collaborator

@eroten eroten commented Aug 21, 2023 •
edited
Loading

Refresh parameters

  • Update default time period from 2019 to 2021
  • update base URL in streetlight_insight()
  • New arguments, updated options in `create_streetlight_analysis()
    • travel_mode_type now includes "All_Vehicles_LBS_Plus", "All_Vehicles_CVD_Plus"
    • New trip attributes available
      • trip_speed_bins
      • trip_duration_bins
      • trip_length_bins
      • trip_circuity_bins
    • unit_of_measure miles or km
    • enable_completion_email
  • Updated tests
  • Increment year, version numbers

Type of change

Please delete options that are not relevant.

  • Bug fix
  • New feature

Package development checklist

  • usethis::use_latest_dependencies()
  • usethis::use_tidy_description()
  • devtools::test()
  • devtools::document(roclets = c('rd', 'collate', 'namespace'))
  • Update DESCRIPTION with new contributors, if neccessary.
  • Double check your documentation
  • styler:::style_active_pkg()
  • rcmdcheck::rcmdcheck()
    • fix errors
    • fix simple warnings and notes

Courtesy checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have tagged this PR appropriately

@eroten eroten added the enhancement New feature or request label Aug 21, 2023
@eroten eroten self-assigned this Aug 21, 2023
@eroten eroten merged commit bf52f66 into main Aug 21, 2023
2 checks passed
@eroten eroten deleted the refresh-parameters branch August 21, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eroten eroten

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eroten