Propagate exception to all pending commands #221
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #220 (see issue for details about the problem fixed here).
The fix consists in iterating over all commands still in the queue while we are running the generic exception handler, and pass each of them the exception being handled by calling their
_feed_error()
method.With the fix, the output of the minimal script reproducing the issue is:
Pay attention to the beginning of the output as there are now the two lines we expect:
showing that the client now receives the error.
The remainder of the output comes from the
MPDClient.__idle_result()
method hooked as "done callback" of the current future. It accessesresult.result()
which causes the exception to be raised again. This is most likely harmless and has nothing to do with the issue being fixed.