Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to httpCompression attributes #273

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

remcoeissing
Copy link

Update to how elements and attributes of httpCompression work.

@shirhatti
Copy link
Contributor

ping @bangbingsyb

Copy link
Contributor

@bangbingsyb bangbingsyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except we may want to clarify the version when the change was in.

| [`dynamicTypes`](dynamictypes/index.md) | Optional element. <br><br>Specifies configuration settings for dynamic compression. |
| [`staticTypes`](statictypes/index.md) | Optional element. <br><br>Specifies configuration settings for static compression. |
| [`scheme`](scheme.md) | Optional element. <br><br>Specifies the compression scheme (Gzip or Deflate) IIS uses to compress client requests. This element can only be configured at server level. |
| [`dynamicTypes`](dynamictypes/index.md) | Optional element. <br><br>Specifies configuration settings for dynamic compression. This element can be configured at site level. |
Copy link
Contributor

@bangbingsyb bangbingsyb Nov 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for making the change for us!

Minor change requested: In fact, dynamicTypes and staticTypes are only allowed to be configured at site level since IIS 10.0 and above. Before IIS 10.0, they can only be configured at server level.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bangbingsyb use the suggestion mechanism so I can accept your suggestion, then I'll S&M this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants