Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for VSCode whole-line autocomplete #351

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

ayim
Copy link
Collaborator

@ayim ayim commented Apr 15, 2022

Summary of changes
Added documentation for VSCode whole-line autocompletions.
Most of the content is from the Readme.MD for the extension itself.

Review Instructions
I recommend reviewing this PR by using github.dev.
Press the "." key, then use the markdown preview (top right bar).

@ayim ayim changed the title Aayim vscwlc Add documentation for VSCode whole-line autocomplete Apr 15, 2022
The extension is supported by Visual Studio Code October 2018 Release 1.29 or later.

AI-assisted IntelliSense for Java requires Java 8 Update 151 or higher.
## Whole-line autocomplete preview
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way the page weaves between talking about the WLC extension and the main extension is confusing. The WLC extension also has a higher minimum version and narrower language support, which should be mentioned.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to Viv's comment here - we should clearly state the constraints/requirements for "whole line completion preview".
We also need to ensure that if we're adopting "Whole-line autocomplete" we do so everywhere it is mentioned (docs AND product)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering whether one way to do this is to open the section with this text to make the link between the preview-ness and the extension clear.

"IntelliCode also has a preview release that allows you to try out whole line completions for Python and JavaScript/TypeScript files.

This preview is provided via a separate extension, which you can acquire here [url]. It requires version X.Y.Z of Visual Studio Code or higher"

An even clearer way might be to move the whole section to its own file and link to it from here, making the separation cleaner. Once the preview period is over we could fold back here.


### Installation

We recommend using the [IntelliCode Completions extension for VS Code]() together with the [main IntelliCode extension for VS Code]().
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These links don't go anywhere yet.


Completions will appear after your cursor as you type, with a faded color. At any time, you can accept the suggestion by pressing the tab key. Additionally, you can dismiss any shown suggestion by pressing the ESC key.

![IntelliCode Completions interpreting IntelliSense completion list selection in Visual Studio Code](../images/intellisenseSelection.gif)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it's worth mentioning that the completion list selection is used to inform which prediction you get

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and possibly that it takes two tab presses

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to Viv's comments. I'd also say, in the sentence about accepting/rejecting the suggestion, to stay consistent with our description elsewhere:

"At any time you can accept the suggestion by pressing the tab key (you will need to press it twice if the IntelliSense list is up). If you don't want to accept the suggestion, you can just keep on typing or press ESC"

Copy link
Collaborator

@DavidObando DavidObando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It reads well, my only comment is on updating the supported version of VSCode.

docs/intellicode-visual-studio-code.md Outdated Show resolved Hide resolved
@vivlimmsft
Copy link
Collaborator

Oh, I think it would also be good to mention snippet insertion's tab interaction

Copy link
Contributor

@markw-t markw-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments; I think a little restructure should clarify the two feature sets (WLC preview vs the rest)

The extension is supported by Visual Studio Code October 2018 Release 1.29 or later.

AI-assisted IntelliSense for Java requires Java 8 Update 151 or higher.
## Whole-line autocomplete preview
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to Viv's comment here - we should clearly state the constraints/requirements for "whole line completion preview".
We also need to ensure that if we're adopting "Whole-line autocomplete" we do so everywhere it is mentioned (docs AND product)

The extension is supported by Visual Studio Code October 2018 Release 1.29 or later.

AI-assisted IntelliSense for Java requires Java 8 Update 151 or higher.
## Whole-line autocomplete preview
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering whether one way to do this is to open the section with this text to make the link between the preview-ness and the extension clear.

"IntelliCode also has a preview release that allows you to try out whole line completions for Python and JavaScript/TypeScript files.

This preview is provided via a separate extension, which you can acquire here [url]. It requires version X.Y.Z of Visual Studio Code or higher"

An even clearer way might be to move the whole section to its own file and link to it from here, making the separation cleaner. Once the preview period is over we could fold back here.


Completions will appear after your cursor as you type, with a faded color. At any time, you can accept the suggestion by pressing the tab key. Additionally, you can dismiss any shown suggestion by pressing the ESC key.

![IntelliCode Completions interpreting IntelliSense completion list selection in Visual Studio Code](../images/intellisenseSelection.gif)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to Viv's comments. I'd also say, in the sentence about accepting/rejecting the suggestion, to stay consistent with our description elsewhere:

"At any time you can accept the suggestion by pressing the tab key (you will need to press it twice if the IntelliSense list is up). If you don't want to accept the suggestion, you can just keep on typing or press ESC"

docs/intellicode-visual-studio-code.md Show resolved Hide resolved
docs/intellicode-visual-studio-code.md Show resolved Hide resolved
The extension is supported by Visual Studio Code October 2018 Release 1.29 or later.

AI-assisted IntelliSense for Java requires Java 8 Update 151 or higher.
## Whole-line autocomplete preview
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we decided on the name to be whole line completions

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what we decided at VS22 launch time with marketing.
Since then, there's been two clarifications

  1. Our copywriter says that whole must always have a dash with line (Brick George has the full details on why this grammar is important)
  2. Autocomplete is more immediately relateable

docs/intellicode-visual-studio-code.md Outdated Show resolved Hide resolved
docs/intellicode-visual-studio-code.md Outdated Show resolved Hide resolved
docs/intellicode-visual-studio-code.md Outdated Show resolved Hide resolved
docs/intellicode-visual-studio-code.md Outdated Show resolved Hide resolved
docs/intellicode-visual-studio-code.md Show resolved Hide resolved
@ayim
Copy link
Collaborator Author

ayim commented Apr 19, 2022

Summary of changes

  • Added info about snippet completion
  • Separated content about whole-line autocompletion to a separate page


Completions will appear after your cursor as you type, with a faded color. When the IntelliSense list is open, its selection is used to inform the whole-line autocompletion.

At any time you can accept the suggestion by pressing the tab key (you will need to press it twice if the IntelliSense list is visible). If you don't want to accept the suggestion, you can just keep on typing or press ESC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change "tab" to "TAB" to keep it consistent with "ESC"

docs/intellicode-visual-studio-code-completions.md Outdated Show resolved Hide resolved

## Provide feedback

If you encounter a problem, you can browse [existing issues](https://github.com/MicrosoftDocs/intellicode/issues) and upvote them using a 👍 "thumbs up" reaction. If you don't see your particular problem, we'd love to hear from you. Include any **Output** window log entries from Visual Studio IntelliCode, Python, Java, JavaScript, or TypeScript with the bug.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be helpful to include a screenshot of how to do this

docs/intellicode-visual-studio-code.md Show resolved Hide resolved
docs/overview.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants