Skip to content

Conversation

@sommarskog
Copy link
Contributor

Corrected the required permission based on the actual behaviour, although this has to be construed as a bug. That is, you don't get an explicit permission error, but only "A severe error occurred on the current command. The results if any should be discarded". Given how long this behaviour has been there, fixing the actual bug is unlikely to pass the triage bar. Thus, better to adopt the documentation.

@prmerger-automator
Copy link
Contributor

@sommarskog : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit e03a284:

✅ Validation status: passed

File Status Preview URL Details
docs/relational-databases/system-stored-procedures/sp-help-spatial-geometry-histogram-transact-sql.md ✅Succeeded

For more details, please refer to the build report.

Corrected the required permission based on the actual behaviour, although this has to be construed as a bug. That is, you don't get an explicit permission error, but only "A severe error occurred on the current command. The results if any should be discarded". Given how long this behaviour has been there, fixing the actual bug is unlikely to pass the triage bar. Thus, better to adopt the documentation.
@rwestMSFT rwestMSFT changed the title Update sp-help-spatial-geometry-histogram-transact-sql.md Update sp-help-spatial-*-histogram-transact-sql.md Dec 8, 2025
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 54b0d42:

✅ Validation status: passed

File Status Preview URL Details
docs/relational-databases/system-stored-procedures/sp-help-spatial-geography-histogram-transact-sql.md ✅Succeeded
docs/relational-databases/system-stored-procedures/sp-help-spatial-geometry-histogram-transact-sql.md ✅Succeeded

For more details, please refer to the build report.

@ttorble ttorble requested a review from Copilot December 8, 2025 16:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request corrects the documented permissions requirements for two spatial histogram stored procedures to reflect actual behavior. The procedures require sysadmin role membership rather than public role with READ ACCESS permissions as previously documented.

Key Changes

  • Updated permission requirements in both sp_help_spatial_geometry_histogram and sp_help_spatial_geography_histogram documentation
  • Changed from "public role with READ ACCESS" to "sysadmin fixed server role"

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
sp-help-spatial-geometry-histogram-transact-sql.md Corrected Permissions section to require sysadmin role
sp-help-spatial-geography-histogram-transact-sql.md Corrected Permissions section to require sysadmin role

@ttorble
Copy link
Contributor

ttorble commented Dec 8, 2025

@markingmyname

Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Dec 8, 2025
@rwestMSFT
Copy link
Contributor

#reassign:rwestMSFT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants