Address feedback and questions on setPreferredSinkId() explainer#1299
Open
SteveBeckerMSFT wants to merge 2 commits intomainfrom
Open
Address feedback and questions on setPreferredSinkId() explainer#1299SteveBeckerMSFT wants to merge 2 commits intomainfrom
SteveBeckerMSFT wants to merge 2 commits intomainfrom
Conversation
gabrielsanbrito
approved these changes
Apr 10, 2026
Contributor
gabrielsanbrito
left a comment
gabrielsanbrito
left a comment
There was a problem hiding this comment.
LGTM % super nit. Feel free to ignore it if not worth the work.
| This API is accessible from the top-level frame and the same-origin sub frames and allows modification of the default audio output for both | ||
| the top-level frame and all sub frames, regardless of their origins. However, it’s important to note that this change does not affect custom | ||
| audio outputs specified using the setSinkId method in media element or audio context. | ||
| After successfully overriding the default audio output device, the promise fulfills with `undefined`. Success does not change the [`sinkId`](https://w3c.github.io/mediacapture-output/#dom-htmlmediaelement-sinkid) attribute of any audio renderer. Only top-level frames may successfully call `setPreferredSinkId()`. After failure, the promise rejects with one of the following errors: |
Contributor
There was a problem hiding this comment.
super nit: Isn't the "with undefined" part redundant given that setPreferredSinkId returns Promise<void>?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disallows child frames from calling
setPreferredSinkId(). Attempts to simplify goals and examples to answer questions about behavior and permissions.