Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration specs #8

Merged
merged 11 commits into from
Jul 14, 2023
Merged

Integration specs #8

merged 11 commits into from
Jul 14, 2023

Conversation

Tshobohwa
Copy link
Collaborator

In this milestone I implemented the following features:

  1. Fixed the n+1 issue while fetching all the posts for a user with their comments,
  • query before fixing the n+1 issue:
    queriesn1
  • Query after fixing the n+1 issue:
    queriesn2
  1. Used Capybara to create tests for:
  • User index page.
  • user show page.
  • post index page.
  • post show page .

Copy link

@zieeco zieeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Team,

Great job so far! 👏
You've done well, there are some issues that you still need to work on to go to the next project, but you are almost there!

To highlight 🎯

  • Fix n+1 problem.✔️
  • Integration test passed. ✔️
  • Descriptive PR. ✔️

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Check the comments under the review.

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were missed by the previous reviewer and addressing them will really improve your application.

Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.

spec/integrations/post_index_spec.rb Show resolved Hide resolved
spec/integrations/post_show_spec.rb Show resolved Hide resolved
Copy link

@Zuhaib042 Zuhaib042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Tshobohwa ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

✅ Well implemented suggested changes
✅ Integration tests are passing

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@cherelemma cherelemma merged commit 7c51537 into dev Jul 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants