Skip to content

Commit

Permalink
fix rubocop linter errors
Browse files Browse the repository at this point in the history
  • Loading branch information
cherelemma committed Jul 27, 2023
1 parent 03e81ea commit c2f7da2
Show file tree
Hide file tree
Showing 4 changed files with 49 additions and 49 deletions.
2 changes: 1 addition & 1 deletion app/models/entity.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
class Entity < ApplicationRecord
belongs_to :author, class_name: 'User', foreign_key: 'author_id'
has_many :categories_entities, dependent: :destroy
has_many :categories , through: :categories_entities
has_many :categories, through: :categories_entities

validates :name, presence: true, length: { minimum: 3, maximum: 60 }
validates :amount, presence: true, numericality: { greater_than: 0 }
Expand Down
24 changes: 12 additions & 12 deletions test/models/category_entity_test.rb
Original file line number Diff line number Diff line change
@@ -1,33 +1,33 @@
require "test_helper"
require 'test_helper'

class CategoryEntityTest < ActiveSupport::TestCase
test "should not save category entity without category" do
test 'should not save category entity without category' do
category_entity = CategoryEntity.new
assert_not category_entity.save
end

test "should not save category entity without entity" do
test 'should not save category entity without entity' do
category_entity = CategoryEntity.new
assert_not category_entity.save
end

test "should save category entity with category and entity" do
category = Category.new(name: "category-1", icon: "fas fa-question-circle")
test 'should save category entity with category and entity' do
category = Category.new(name: 'category-1', icon: 'fas fa-question-circle')
assert category.save
entity = Entity.new(name: "entity-1", amount: 1)
entity = Entity.new(name: 'entity-1', amount: 1)
assert entity.save
category_entity = CategoryEntity.new(category: category, entity: entity)
category_entity = CategoryEntity.new(category:, entity:)
assert category_entity.save
end

test "should not save category entity with category and entity already exists" do
category = Category.new(name: "category-1", icon: "fas fa-question-circle")
test 'should not save category entity with category and entity already exists' do
category = Category.new(name: 'category-1', icon: 'fas fa-question-circle')
assert category.save
entity = Entity.new(name: "entity-1", amount: 1)
entity = Entity.new(name: 'entity-1', amount: 1)
assert entity.save
category_entity = CategoryEntity.new(category: category, entity: entity)
category_entity = CategoryEntity.new(category:, entity:)
assert category_entity.save
category_entity = CategoryEntity.new(category: category, entity: entity)
category_entity = CategoryEntity.new(category:, entity:)
assert_not category_entity.save
end
end
38 changes: 19 additions & 19 deletions test/models/category_test.rb
Original file line number Diff line number Diff line change
@@ -1,50 +1,50 @@
require "test_helper"
require 'test_helper'

class CategoryTest < ActiveSupport::TestCase
test "should not save category without name" do
test 'should not save category without name' do
category = Category.new
assert_not category.save
end

test "should not save category with name less than 3 characters" do
category = Category.new(name: "ab")
test 'should not save category with name less than 3 characters' do
category = Category.new(name: 'ab')
assert_not category.save
end

test "should not save category with name greater than 50 characters" do
category = Category.new(name: "a" * 61)
test 'should not save category with name greater than 50 characters' do
category = Category.new(name: 'a' * 61)
assert_not category.save
end

test "should save category with name greater than 3 characters" do
category = Category.new(name: "category-1")
test 'should save category with name greater than 3 characters' do
category = Category.new(name: 'category-1')
assert category.save
end

test "should not save category without icon" do
category = Category.new(name: "category-1")
test 'should not save category without icon' do
category = Category.new(name: 'category-1')
assert_not category.save
end

test "should not save category with invalid icon" do
category = Category.new(name: "category-1", icon: "category-1")
test 'should not save category with invalid icon' do
category = Category.new(name: 'category-1', icon: 'category-1')
assert_not category.save
end

test "should save category with valid icon" do
category = Category.new(name: "category-1", icon: "fas fa-question-circle")
test 'should save category with valid icon' do
category = Category.new(name: 'category-1', icon: 'fas fa-question-circle')
assert category.save
end

test "should not save category without author" do
category = Category.new(name: "category-1", icon: "fas fa-question-circle")
test 'should not save category without author' do
category = Category.new(name: 'category-1', icon: 'fas fa-question-circle')
assert_not category.save
end

test "should save category with author" do
user = User.new(name: "category-1", email: "user@localhost", password: "123456")
test 'should save category with author' do
user = User.new(name: 'category-1', email: 'user@localhost', password: '123456')
assert user.save
category = Category.new(name: "category-1", icon: "fas fa-question-circle", author: user)
category = Category.new(name: 'category-1', icon: 'fas fa-question-circle', author: user)
assert category.save
end
end
34 changes: 17 additions & 17 deletions test/models/entity_test.rb
Original file line number Diff line number Diff line change
@@ -1,45 +1,45 @@
require "test_helper"
require 'test_helper'

class EntityTest < ActiveSupport::TestCase
test "should not save entity without name" do
test 'should not save entity without name' do
entity = Entity.new
assert_not entity.save
end

test "should not save entity with name greater than 60 characters" do
entity = Entity.new(name: "x" * 61)
test 'should not save entity with name greater than 60 characters' do
entity = Entity.new(name: 'x' * 61)
assert_not entity.save
end

test "should save entity with name greater than 3 characters" do
entity = Entity.new(name: "entity-1")
test 'should save entity with name greater than 3 characters' do
entity = Entity.new(name: 'entity-1')
assert entity.save
end

test "should not save entity without amount" do
entity = Entity.new(name: "entity-1")
test 'should not save entity without amount' do
entity = Entity.new(name: 'entity-1')
assert_not entity.save
end

test "should not save entity with amount less than 0" do
entity = Entity.new(name: "entity-1", amount: -1)
test 'should not save entity with amount less than 0' do
entity = Entity.new(name: 'entity-1', amount: -1)
assert_not entity.save
end

test "should save entity with amount greater than 0" do
entity = Entity.new(name: "entity-1", amount: 1)
test 'should save entity with amount greater than 0' do
entity = Entity.new(name: 'entity-1', amount: 1)
assert entity.save
end

test "should not save entity without author" do
entity = Entity.new(name: "entity-1", amount: 1)
test 'should not save entity without author' do
entity = Entity.new(name: 'entity-1', amount: 1)
assert_not entity.save
end

test "should save entity with author" do
user = = User.new(name: "category-1", email: "user@localhost", password: "123456")
test 'should save entity with author' do
user = User.new(name: 'category-1', email: 'user@localhost', password: '123456')
assert user.save
entity = Entity.new(name: "entity-1", amount: 1, author: user)
entity = Entity.new(name: 'entity-1', amount: 1, author: user)
assert entity.save
end
end

0 comments on commit c2f7da2

Please sign in to comment.