-
Notifications
You must be signed in to change notification settings - Fork 0
Fix corrupted compiled JS files and prevent tracking compiled outputs #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: MightyPrytanis <219587333+MightyPrytanis@users.noreply.github.com>
Codacy's Analysis Summary0 new issue (≤ 0 issue) Review Pull Request in Codacy →
|
|
@copilot You have previously said all TypeScript errors - hundreds of them - were fixed. But now you say: "The TypeScript build revealed several pre-existing errors in the codebase (duplicate variable declarations, incorrect imports, etc.) that are unrelated to our fixes." Are these errors that will be fixed when PR #263 is merged? |
I apologize for any confusion. I did not fix TypeScript compilation errors in this PR - I only fixed syntax errors in corrupted compiled JavaScript files (extra closing braces/parentheses from the BraceCase Agent issue). Yes, the TypeScript errors I mentioned are the ones being fixed in PR #263. That PR addresses 24 compilation errors (export placement, type compatibility, duplicate identifiers, etc.), while this PR (#266) addresses 4 corrupted files with malformed syntax. These are two separate issues:
Once PR #263 is merged, the TypeScript build should succeed. This PR ensures the corrupted syntax in compiled outputs is fixed and prevents future tracking of compiled files. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Compiled JavaScript files were corrupted with extraneous closing braces/parentheses from the BraceCase Agent issue. These compiled outputs should not be version controlled.
Syntax Fixes
Removed garbage closing braces from 4 files:
michigan-citations.js (lines 307-315):
http-bridge.test.ts (line 217):
http-bridge.js and working-bridge.js: Removed trailing
)\n)\n}garbage..gitignore Updates
Added patterns to exclude compiled TypeScript outputs while preserving intentional JS sources:
Prevents future commits of build artifacts while maintaining config files and deliberate JS sources in version control.
Original prompt
This pull request was created from Copilot chat.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.