This repository was archived by the owner on Mar 13, 2023. It is now read-only.
provide a simple css selector to old message#18
Open
am wants to merge 2 commits intoMigracode-Barcelona:masterfrom
Open
provide a simple css selector to old message#18am wants to merge 2 commits intoMigracode-Barcelona:masterfrom
am wants to merge 2 commits intoMigracode-Barcelona:masterfrom
Conversation
Currently on Week1/exercise6>point 4 we ask: > Make yesterday's message partially transparent to show it is old. This is particularly confusing when learning the first CSS selectors, thus adding a specific class to the entire element will help solving this. See: https://migracodebarcelona.slack.com/archives/CMDSP2CQ2/p1584005696039700
|
I agree, this should be a simple selector. We should also remove the class from the |
Member
Author
Thank you for the review @redspanner! I've updated the PR with your feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently on Week-1 > Exercise-6 > Point 4 we ask:
This is particularly confusing when learning the first CSS selectors, thus adding a specific class to the entire element will help to solve this.
See: https://migracodebarcelona.slack.com/archives/CMDSP2CQ2/p1584005696039700