This repository was archived by the owner on Mar 13, 2023. It is now read-only.
provide base code without margin or padding#20
Open
am wants to merge 1 commit intoMigracode-Barcelona:masterfrom
Open
provide base code without margin or padding#20am wants to merge 1 commit intoMigracode-Barcelona:masterfrom
am wants to merge 1 commit intoMigracode-Barcelona:masterfrom
Conversation
The code we provide already matches the final result. This happens because the CSS files are imported form other exercise. This commit removes the import and adds only the base styles without any margin or padding.
kossa21
added a commit
to kossa21/html-css-git-exercises
that referenced
this pull request
Mar 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code we provide already matches the final result. This happens because of the
CSS files are imported from another exercise. This commit removes the import and
adds only the base styles without any margin or padding.
The exercise asks the following:
With the current changes this is what the students will see:
And this is the expected output:
Reference: https://migracodebarcelona.slack.com/archives/CU7AHBFR9/p1584199895029900?thread_ts=1584199298.023200