fix: make categories under Feed an optional type #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feed["categories"]
is defined asCategory[]
.However, it is actually
Category[] | undefined
.The process is to assign a value to
categories
after it is cast toFeed
. However, just before that, it is verified withif
, and the assignment may be skipped. This validation also indicates to the compiler that it isNonNullable
and the assignment toCategory[]
is allowed in theif
statement.code in the relevant section
rss/src/mappers/mapper.ts
Lines 379 to 384 in ebee31f
The fundamental solution is to refactor the process with type assertions, but since this would be a major change, only the type definitions are modified in this PR.
The main changes are the following commits
6d98b1f